From 3d23c7db114e2879f650db6d622dad0fb82e31da Mon Sep 17 00:00:00 2001 From: Alon Zakai Date: Wed, 24 Jul 2019 18:19:46 -0700 Subject: [PATCH] maybe? [ci skip] --- src/wasm/wasm-binary.cpp | 4 ++-- test/complexBinaryNames.wasm.fromBinary | 4 ++-- test/complexTextNames.wast.fromBinary | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/wasm/wasm-binary.cpp b/src/wasm/wasm-binary.cpp index 3d9a1ba9bef..4fb0a4329c3 100644 --- a/src/wasm/wasm-binary.cpp +++ b/src/wasm/wasm-binary.cpp @@ -2054,7 +2054,7 @@ static char formatNibble(int nibble) { return nibble < 10 ? '0' + nibble : 'a' - 10 + nibble; } -static void escapeName(Name& name) { +void escapeName(Name& name) { bool allIdChars = true; for (const char* p = name.str; allIdChars && *p; p++) { allIdChars = isIdChar(*p); @@ -2098,7 +2098,7 @@ void WasmBinaryBuilder::readNames(size_t payloadLen) { for (size_t i = 0; i < num; i++) { auto index = getU32LEB(); auto rawName = getInlineString(); - escapeName(rawName); + //escapeName(rawName); auto name = rawName; // De-duplicate names by appending .1, .2, etc. for (int i = 1; !usedNames.insert(name).second; ++i) { diff --git a/test/complexBinaryNames.wasm.fromBinary b/test/complexBinaryNames.wasm.fromBinary index e50a9134d40..a6195dd3759 100644 --- a/test/complexBinaryNames.wasm.fromBinary +++ b/test/complexBinaryNames.wasm.fromBinary @@ -1,11 +1,11 @@ (module (type $0 (func)) (export "$zoo (.bar)" (func $1)) - (func $foo\20\28.bar\29 (; 0 ;) (type $0) + (func "$foo (.bar)" (; 0 ;) (type $0) (nop) ) (func $1 (; 1 ;) (type $0) - (call $foo\20\28.bar\29) + (call "$foo (.bar)") ) ) diff --git a/test/complexTextNames.wast.fromBinary b/test/complexTextNames.wast.fromBinary index e50a9134d40..a6195dd3759 100644 --- a/test/complexTextNames.wast.fromBinary +++ b/test/complexTextNames.wast.fromBinary @@ -1,11 +1,11 @@ (module (type $0 (func)) (export "$zoo (.bar)" (func $1)) - (func $foo\20\28.bar\29 (; 0 ;) (type $0) + (func "$foo (.bar)" (; 0 ;) (type $0) (nop) ) (func $1 (; 1 ;) (type $0) - (call $foo\20\28.bar\29) + (call "$foo (.bar)") ) )