Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
asyncify: support *-matching in whitelist and blacklist #2344
See emscripten-core/emscripten#9381 for rationale.
The impacted code seem to lack proper testing framework, ideally we'd unit-test
Also currently the performance appears significantly slower (~+30% time). I'm not sure if this is purely related to the matching algorithm, in which case we may need a larger beast like http://developforperformance.com/MatchingWildcards_AnImprovedAlgorithmForBigData.html
Looks like this is failing on an emscripten test in our integration CI, see the bottom of https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket.appspot.com/8901492015302662944/+/steps/Emscripten_testsuite__upstream__other_/0/stdout
Looks like the warning prints escaped names now, which I think wasn't intended here?
(Until this is resolved no binaryen changes, including this one, can roll into emsdk releases.)
Oh, this does look bad: the function name is
A proper fix might be to use a different character for wildcards, but that's annoying.
We do need to fix the warning here a little, I have a PR in progress.
This is part of the fix for https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket.appspot.com/8901492015302662960/+/steps/Emscripten_testsuite__upstream__other_/0/stdout Specifically it fixes that the name shown there should not be escaped. Followup for #2344