Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDWARF: Properly emit signed 32 bit values for advance_line #2625
Conversation
…the 64-bit size in SData)
|
Assuming this works (too bad we can't verify raw data with llvm-dwarfdump), LGTM. |
This comment has been minimized.
This comment has been minimized.
|
I confirmed that with this PR, building with |
This comment has been minimized.
This comment has been minimized.
billti
commented
Jan 30, 2020
|
@kripken I just attempted to emit DWARF for a simple program via the -gforce_dwarf flag and it crashed with the below. Let me know if this is a known issue, or if I should log and new one (and in which repo, as I'm unclear exactly which project is the root of this issue). I just yesterday confirmed emscripten, and
|
This comment has been minimized.
This comment has been minimized.
|
@billti That looks familiar, so it might be a bug that was fixed meanwhile. Please test with |
This comment has been minimized.
This comment has been minimized.
billti
commented
Jan 30, 2020
|
Not seeing an issue now. Thanks! I'll open up a new issue if I see any recurrence. |
kripken commentedJan 24, 2020
The LLVM SData field is 64-bit (to support 64-bit
addresses I suppose) so when we assigned to it we
actually led it to emit an LEB for a signed 64-bit value
that is an unsigned 32-bit one. This worked in LLVM
(where I guess it forces the value to 32-bit anyhow?)
but failed in gimli (where I guess it doesn't?).
Found by @RReverser