From 757254b06d8a23b1620dc8eb2a2efeee80c29c9a Mon Sep 17 00:00:00 2001 From: Thomas Lively Date: Fri, 13 Dec 2024 13:07:21 -0800 Subject: [PATCH] Address comments from #7149 The PR was accidentally merged without these fixes included. --- CHANGELOG.md | 3 ++- src/wasm-binary.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 52e453ee48f..b6ceeb8da1c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,7 +17,8 @@ Current Trunk - BinaryenSelect no longer takes a type parameter. - AutoDrop APIs have been removed. - - Binaryen now supports parsing control flow structures with parameter types. + - Binaryen now supports parsing control flow structures with parameter types by + lowering them away in the parsers.. v120 ---- diff --git a/src/wasm-binary.h b/src/wasm-binary.h index 61f4faf69e2..bece0af8ed9 100644 --- a/src/wasm-binary.h +++ b/src/wasm-binary.h @@ -1467,7 +1467,7 @@ class WasmBinaryReader { bool getBasicType(int32_t code, Type& out); bool getBasicHeapType(int64_t code, HeapType& out); - // Get the signature of control flow structure. + // Get the signature of a control flow structure. Signature getBlockType(); // Read a value and get a type for it. Type getType();