Skip to content

LegalizeJSInterface: Fix up RefFuncs in global code too #8061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2025
+9 −0
Merged

LegalizeJSInterface: Fix up RefFuncs in global code too #8061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8627f94
fix
kripken Nov 19, 2025
0b8d4ba
test
kripken Nov 19, 2025
1bfc178
test
kripken Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/passes/LegalizeJSInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,7 @@ struct LegalizeAndPruneJSInterface : public LegalizeJSInterface {

// RefFunc types etc. need updating.
ReFinalize().run(getPassRunner(), module);
ReFinalize().runOnModuleCode(getPassRunner(), module);

// TODO: globals etc.
}
Expand Down
8 changes: 8 additions & 0 deletions test/lit/passes/legalize-and-prune-js-interface.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@

;; CHECK: (import "env" "imported-64" (func $legalimport$imported-64 (type $9) (param i32 f64) (result i32)))

;; CHECK: (global $global funcref (ref.func $imported-v128))
(global $global funcref
;; The ref target will turn from an import into an internal function. We'd
;; error if we do not update this ref.func while doing so, to make its type
;; exact.
(ref.func $imported-v128)
)

;; CHECK: (func $imported-v128 (type $0) (result v128)
;; CHECK-NEXT: (v128.const i32x4 0x00000000 0x00000000 0x00000000 0x00000000)
;; CHECK-NEXT: )
Expand Down
Loading