From c2eb4ea99424680149a785bcdb9b6d3e247d5d6e Mon Sep 17 00:00:00 2001 From: stevenfontanella Date: Fri, 5 Dec 2025 00:58:37 +0000 Subject: [PATCH 1/2] Fix uninitialized member --- src/support/small_vector.h | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/src/support/small_vector.h b/src/support/small_vector.h index 83ada782f23..86f7bf70116 100644 --- a/src/support/small_vector.h +++ b/src/support/small_vector.h @@ -30,26 +30,10 @@ namespace wasm { -// We don't understand this warning, only here and only on aarch64 and riscv64, -// we suspect it's spurious so disabling for now. -// -// For context: https://github.com/WebAssembly/binaryen/issues/6311 - -#if defined(__aarch64__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wmaybe-uninitialized" -#endif - -// https://github.com/WebAssembly/binaryen/issues/6410 -#if defined(__riscv) && __riscv_xlen == 64 -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wuninitialized" -#endif - template class SmallVector { // fixed-space storage size_t usedFixed = 0; - std::array fixed; + std::array fixed{}; // flexible additional storage std::vector flexible; From 5510bd06774f5118d499034db29f110dc9febd84 Mon Sep 17 00:00:00 2001 From: stevenfontanella Date: Fri, 5 Dec 2025 18:17:58 +0000 Subject: [PATCH 2/2] Remove more pragmas --- src/support/small_vector.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/support/small_vector.h b/src/support/small_vector.h index 86f7bf70116..8cad6ade29e 100644 --- a/src/support/small_vector.h +++ b/src/support/small_vector.h @@ -230,14 +230,6 @@ struct ZeroInitSmallVector : public SmallVector { } }; -#if defined(__aarch64__) -#pragma GCC diagnostic pop -#endif - -#if defined(__riscv) && __riscv_xlen == 64 -#pragma GCC diagnostic pop -#endif - } // namespace wasm #endif // wasm_support_small_vector_h