Skip to content

Fix uninitialized member #8094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevenfontanella merged 2 commits into from
Dec 5, 2025
+1 −25
Merged

Fix uninitialized member #8094

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2eb4ea
Fix uninitialized member
stevenfontanella Dec 5, 2025
5510bd0
Remove more pragmas
stevenfontanella Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions src/support/small_vector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,26 +30,10 @@

namespace wasm {

// We don't understand this warning, only here and only on aarch64 and riscv64,
// we suspect it's spurious so disabling for now.
//
// For context: https://github.com/WebAssembly/binaryen/issues/6311

#if defined(__aarch64__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#endif

// https://github.com/WebAssembly/binaryen/issues/6410
#if defined(__riscv) && __riscv_xlen == 64
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wuninitialized"
#endif

template<typename T, size_t N> class SmallVector {
// fixed-space storage
size_t usedFixed = 0;
std::array<T, N> fixed;
std::array<T, N> fixed{};

// flexible additional storage
std::vector<T> flexible;
Expand Down Expand Up @@ -246,14 +230,6 @@ struct ZeroInitSmallVector : public SmallVector<T, N> {
}
};

#if defined(__aarch64__)
#pragma GCC diagnostic pop
#endif

#if defined(__riscv) && __riscv_xlen == 64
#pragma GCC diagnostic pop
#endif

} // namespace wasm

#endif // wasm_support_small_vector_h
Loading