Skip to content

NFC: Use const EffectAnalyzer& in ostream operator #8769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevenfontanella merged 1 commit into from
May 24, 2026
+7 −9
Merged

NFC: Use const EffectAnalyzer& in ostream operator #8769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/ir/effects.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
#include "ir/effects.h"
#include "wasm.h"

namespace std {
namespace wasm {

std::ostream& operator<<(std::ostream& o, wasm::EffectAnalyzer& effects) {
std::ostream& operator<<(std::ostream& o, const EffectAnalyzer& effects) {
o << "EffectAnalyzer {\n";
if (effects.branchesOut) {
o << "branchesOut\n";
Expand Down Expand Up @@ -87,10 +87,10 @@ std::ostream& operator<<(std::ostream& o, wasm::EffectAnalyzer& effects) {
if (effects.implicitTrap) {
o << "implicitTrap\n";
}
if (effects.readOrder != wasm::MemoryOrder::Unordered) {
if (effects.readOrder != MemoryOrder::Unordered) {
o << "readOrder " << effects.readOrder << "\n";
}
if (effects.writeOrder != wasm::MemoryOrder::Unordered) {
if (effects.writeOrder != MemoryOrder::Unordered) {
o << "writeOrder " << effects.writeOrder << "\n";
}
if (effects.throws_) {
Expand Down Expand Up @@ -160,4 +160,4 @@ std::ostream& operator<<(std::ostream& o, wasm::EffectAnalyzer& effects) {
return o;
}

} // namespace std
} // namespace wasm
6 changes: 2 additions & 4 deletions src/ir/effects.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1496,10 +1496,8 @@ class ShallowEffectAnalyzer : public EffectAnalyzer {
}
};

} // namespace wasm
std::ostream& operator<<(std::ostream& o, const EffectAnalyzer& effects);

namespace std {
std::ostream& operator<<(std::ostream& o, wasm::EffectAnalyzer& effects);
} // namespace std
} // namespace wasm

#endif // wasm_ir_effects_h
Loading