[wasm-split] Move some code (NFC)#8815
Merged
Merged
Conversation
This just moves some code to make future diff tidier. This makes `walkSegments` a lambda function within `shareImportableItems` because it is only used within that function, and this adds the dispatch table and segments to the primary's used list within `getUsedNames` rather than outside.
tlively
approved these changes
Jun 8, 2026
| auto walkSegments = [](auto& walker, Module* module) { | ||
| walker.setModule(module); | ||
| for (auto& curr : module->elementSegments) { | ||
| if (curr->offset) { |
Member
There was a problem hiding this comment.
Let's add a TODO to walk the segment's init expression as well. (init segment support was added after this code was originally written, IIRC.)
Member
Author
There was a problem hiding this comment.
You mean #8405? It's in tables, not segments. I'll just do that as a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just moves some code to make future diff tidier. This makes
walkSegmentsa lambda function withinshareImportableItemsbecause it is only used within that function, and this adds the dispatch table and segments to the primary's used list withingetUsedNamesrather than outside.