[test] Remove duplicate tests #1314
Conversation
| ) | ||
|
|
||
| ;; Signed LEB128 must not be overlong | ||
| (assert_malformed |
There was a problem hiding this comment.
This one and several tests below are duplicated at:
Line 458 in f607ec9
There was a problem hiding this comment.
Also
spec/test/core/binary-leb128.wast
Line 481 in f607ec9
| ) | ||
|
|
||
| ;; Signed LEB128s sign-extend | ||
| (assert_malformed |
There was a problem hiding this comment.
This one and several tests below are duplicated at:
Line 672 in f607ec9
There was a problem hiding this comment.
Also
spec/test/core/binary-leb128.wast
Line 883 in f607ec9
| ) | ||
|
|
||
| ;; Unsigned LEB128s zero-extend | ||
| (assert_malformed |
There was a problem hiding this comment.
Also
spec/test/core/binary-leb128.wast
Line 524 in f607ec9
| ) | ||
| "integer representation too long" | ||
| ) | ||
| (assert_malformed |
There was a problem hiding this comment.
Also
spec/test/core/binary-leb128.wast
Line 404 in f607ec9
|
|
||
|
|
||
| ;; Unsigned LEB128 must not be overlong | ||
| (assert_malformed |
There was a problem hiding this comment.
Also
spec/test/core/binary-leb128.wast
Line 216 in f607ec9
test/core/binary.wast
Outdated
| "\05\08\01" ;; Memory section with 1 entry | ||
| "\00\82\80\80\80\80\00" ;; no max, minimum 2 with one byte too many | ||
| ) | ||
| "integer representation too long" |
There was a problem hiding this comment.
This test is duplicated at
Line 372 in f607ec9
In this file I generally deleted the first occurrence and left the second occurrence (because it looked like more tests in the second part). For this test I did the same, but GitHub here shows the diff as if I removed the second occurrence (at line 373)
| "type mismatch" | ||
| ) | ||
|
|
||
| (assert_invalid |
There was a problem hiding this comment.
These are duplicated just above, at lines 389-406.
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Thanks for spotting! Git merge is dangerous sometimes.
|
Now I noticed that many tests added to |
| (assert_malformed (module binary "\00asm" "\01\00\00\00" "\81\00\01\00") "malformed section id") | ||
| (assert_malformed (module binary "\00asm" "\01\00\00\00" "\ff\00\01\00") "malformed section id") | ||
|
|
||
| ;; Unsigned LEB128 can have non-minimal length |
| "\00\82\80\80\80\00" ;; no max, minimum 2 | ||
| ) | ||
|
|
||
| ;; Signed LEB128 can have non-minimal length |
There was a problem hiding this comment.
spec/test/core/binary-leb128.wast
Line 157 in f607ec9
| "integer representation too long" | ||
| ) | ||
|
|
||
| ;; Unsigned LEB128 must not be overlong |
There was a problem hiding this comment.
spec/test/core/binary-leb128.wast
Line 216 in f607ec9
| "integer representation too long" | ||
| ) | ||
|
|
||
| ;; Signed LEB128 must not be overlong |
There was a problem hiding this comment.
spec/test/core/binary-leb128.wast
Line 481 in f607ec9
| "integer representation too long" | ||
| ) | ||
|
|
||
| ;; Unsigned LEB128s zero-extend |
There was a problem hiding this comment.
spec/test/core/binary-leb128.wast
Line 524 in f607ec9
| ) | ||
| "integer too large" | ||
| ) | ||
| (assert_malformed |
There was a problem hiding this comment.
spec/test/core/binary-leb128.wast
Line 730 in f607ec9
| "integer too large" | ||
| ) | ||
|
|
||
| ;; Signed LEB128s sign-extend |
There was a problem hiding this comment.
spec/test/core/binary-leb128.wast
Line 883 in f607ec9
| "integer too large" | ||
| ) | ||
|
|
||
| ;; Local number is unsigned 32 bit |
There was a problem hiding this comment.
This one is duplicated just above.
| "\0b" ;; end | ||
| ) | ||
|
|
||
| (module binary |
There was a problem hiding this comment.
Moved this test and the next one to binary-leb128.wast, because there're other tests checking encoding of table/memory index.
|
@gumb0, this PR is stale and has conflicts. Do you still intend to land it? |
gumb0
force-pushed
the
remove-duplicate-tests
branch
from
50cc418 to
eea475e
Compare
gumb0
force-pushed
the
remove-duplicate-tests
branch
from
eea475e to
5f05d3b
Compare
I have rebassed it now and squached two commits, it should be reviewable. |
|
Cool, thanks! |
2 participants
I noticed some tests that were duplicated after #1287.