Skip to content

[interpreter] Fix JS conversion in assertions #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

[interpreter] Fix JS conversion in assertions #1989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2cdcb0
[interpreter] Fix JS conversion in assertions
dschuff Sep 26, 2025
992a37b
remove submodule diff
dschuff Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions interpreter/script/js.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,15 +776,15 @@ let of_action env act =

let of_assertion' env act loc name args wrapper_opt =
let act_js, act_wrapper_opt = of_action env act in
let js = name ^ "(() => " ^ act_js ^ loc ^ String.concat ", " ("" :: args) ^ ")" in
let js = name ^ "(() => " ^ act_js ^ ", " ^ loc ^ String.concat ", " ("" :: args) ^ ")" in
match act_wrapper_opt with
| None -> js ^ ";"
| Some (act_wrapper, out) ->
let run_name, wrapper =
match wrapper_opt with
| None -> name, run
| Some wrapper -> "run", wrapper
in run_name ^ "(() => " ^ act_wrapper (wrapper out) act.at ^ loc ^ "); // " ^ js
in run_name ^ "(() => " ^ act_wrapper (wrapper out) act.at ^ ", " ^ loc ^ "); // " ^ js

let of_assertion env ass =
let loc = of_loc ass.at in
Expand Down