Test that a function with >4KB of locals cannot avoid a stack overflow trap #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewScheidecker
force-pushed
the
skip-stack-guard-page-test
branch
from
69e2036 to
8dcafd3
Compare
Contributor
Author
|
Update: made it less likely that the test gets lucky and hits a guard page at the end of the stack. |
Member
|
LGTM with one nit: can you break those long lines (ideally at 80 cols)? |
AndrewScheidecker
force-pushed
the
skip-stack-guard-page-test
branch
from
8dcafd3 to
f099512
Compare
Contributor
Author
Sure, updated. |
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
…mbly#445) Load lane and store lane instructions added in WebAssembly#350.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the right place for this, but I made this test as a proof of concept of a vulnerability in WAVM. I doubt the browser implementations are vulnerable to this, but any implementation that doesn't emit stack probes or otherwise check for stack overflow in the function prologue will have the same problem.
On Windows, LLVM will correctly emit stack probes for functions that use more than 4KB of stack space, and WAVM passes this test. On other platforms, LLVM doesn't emit stack probes, and WAVM does not pass this test.