Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated draft #2

Merged
merged 10 commits into from
Nov 29, 2022
Merged

updated draft #2

merged 10 commits into from
Nov 29, 2022

Conversation

Mossaka
Copy link
Collaborator

@Mossaka Mossaka commented Nov 1, 2022

Signed-off-by: GitHub <noreply@github.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Dan Chiarlone <danilochiarlone@gmail.com>
Mossaka and others added 4 commits November 1, 2022 15:38
Co-authored-by: Dan Chiarlone <danilochiarlone@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: GitHub <noreply@github.com>
@danbugs
Copy link
Collaborator

danbugs commented Nov 2, 2022

I think we need to discuss more if we really want bulk-get/bulk-put(and a missing bulk-delete) without transactions - will people really use the bulk-put function if it might fail and only put half of their keys? If we don't have transactions, I feel like we're gonna start to see a lot of people doing:

// ...
if kv.bulk_put(list_of_kv_pairs).is_err()) {
  kv.bulk_delete(list_of_kv_pairs);
}
// ...

@ricochet
Copy link
Contributor

ricochet commented Nov 3, 2022

A place for inspiration and a place where this proposal will need to be incorporated: https://github.com/wasmCloud/interfaces/tree/main/keyvalue

Note, thar be dragons around some keywords in python (delete).

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ricochet
Copy link
Contributor

ricochet commented Nov 4, 2022

There's a mismatch between the proposal name and the high-level interface ("wasi:kv" without store). I think this proposal should be renamed to wasi-kv. Store implies an expectation of persistence to storage, usually in a DB-like thing. Common implementations may also be virtual/in-memory or implemented using a filesystem.

It may be worth including a prototype of what the world files for this may look like.

Signed-off-by: GitHub <noreply@github.com>
@Mossaka
Copy link
Collaborator Author

Mossaka commented Nov 7, 2022

I think this proposal should be renamed to wasi-kv

My concern is that wasi-kv might not be clear to people what this proposal is about. Maybe wasi-keyvalue is better?

@autodidaddict
Copy link
Contributor

I think this proposal should be renamed to wasi-kv

My concern is that wasi-kv might not be clear to people what this proposal is about. Maybe wasi-keyvalue is better?

yeah I think not using the word store is the clarifying action there. I'm fine with wasi-keyvalue

@Mossaka
Copy link
Collaborator Author

Mossaka commented Nov 14, 2022

I don't have permission to rename the repo to wasi-keyvalue. Ping @linclark for help~

@linclark
Copy link
Member

Done!

Mossaka and others added 2 commits November 29, 2022 01:18
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
@Mossaka Mossaka merged commit ce608e4 into WebAssembly:main Nov 29, 2022
@Mossaka Mossaka deleted the draft branch November 29, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants