-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated draft #2
Conversation
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Dan Chiarlone <danilochiarlone@gmail.com>
Co-authored-by: Dan Chiarlone <danilochiarlone@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
I think we need to discuss more if we really want // ...
if kv.bulk_put(list_of_kv_pairs).is_err()) {
kv.bulk_delete(list_of_kv_pairs);
}
// ... |
A place for inspiration and a place where this proposal will need to be incorporated: https://github.com/wasmCloud/interfaces/tree/main/keyvalue Note, thar be dragons around some keywords in python (delete). |
There's a mismatch between the proposal name and the high-level interface ("wasi:kv" without store). I think this proposal should be renamed to wasi-kv. Store implies an expectation of persistence to storage, usually in a DB-like thing. Common implementations may also be virtual/in-memory or implemented using a filesystem. It may be worth including a prototype of what the world files for this may look like. |
Signed-off-by: GitHub <noreply@github.com>
My concern is that wasi-kv might not be clear to people what this proposal is about. Maybe wasi-keyvalue is better? |
yeah I think not using the word |
I don't have permission to rename the repo to |
Done! |
merged upstream
Rendered version: https://github.com/WebAssembly/wasi-kv-store/blob/e0830360a0f0184b991aeb0eb7e6b342ad385e15/README.md
Signed-off-by: GitHub noreply@github.com