Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(AudioGain): AudioGain interface not needed? #154

Closed
olivierthereaux opened this issue Sep 11, 2013 · 6 comments

Comments

Projects
None yet
1 participant
@olivierthereaux
Copy link
Contributor

commented Sep 11, 2013

Originally reported on W3C Bugzilla ISSUE-17338 Tue, 05 Jun 2012 11:31:50 GMT
Reported by Philip Jägenstedt
Assigned to

Audio-ISSUE-44 (AudioGain): AudioGain interface not needed? [Web Audio API]

http://www.w3.org/2011/audio/track/issues/44

Raised by: Philip Jägenstedt
On product: Web Audio API

https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioGain-section

The interface is empty and only used in AudioGainNode. Suggest merging the two sections and making AudioGainNode.gain a plain AudioParam, like e.g. DelayNode.delayTime.

@olivierthereaux

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2013

Original comment by Olivier Thereaux on W3C Bugzilla. Thu, 07 Jun 2012 15:59:14 GMT

Comment from Chris Rogers, 18 May 2012

Yes, I think this is better. I'll fix it

@olivierthereaux

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2013

Original comment by Chris Rogers on W3C Bugzilla. Tue, 02 Oct 2012 19:36:44 GMT

Agreed, AudioGain is not needed. Fixed:
https://dvcs.w3.org/hg/audio/rev/1357959b0188
https://dvcs.w3.org/hg/audio/rev/24bbac1a495c

@olivierthereaux

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2013

Original comment by Marcus Geelnard (Opera) on W3C Bugzilla. Wed, 03 Oct 2012 07:14:02 GMT

I think there's a typo in the new text:

"An AudioGain object representing the amount of gain to apply."
^^^^^^^^^

should probably be:

"An AudioParam object representing the amount of gain to apply."
^^^^^^^^^^

@olivierthereaux

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2013

Original comment by Philip Jägenstedt on W3C Bugzilla. Wed, 03 Oct 2012 08:10:45 GMT

Marcus, that was fixed in the second commit. https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html looks good to me now.

@olivierthereaux

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2013

Original comment by Marcus Geelnard (Opera) on W3C Bugzilla. Wed, 03 Oct 2012 08:14:47 GMT

(In reply to comment #4)

Marcus, that was fixed in the second commit.
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html looks
good to me now.

My bad - it's fine now.

@olivierthereaux

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2013

Original comment by Olivier Thereaux on W3C Bugzilla. Tue, 16 Oct 2012 13:58:25 GMT

Looks good, no objection. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.