From ab6c5006f9e2eedb41208107ed62c7b2d4aeb4eb Mon Sep 17 00:00:00 2001 From: Raymond Toy Date: Thu, 23 Jun 2016 15:16:18 -0700 Subject: [PATCH 1/4] Fix #824: add OfflineAudioDestinationNode Add OfflineAudioDestinationNode so we can specify that the channel count and channel mode cannot be changed after construction. Also, explicitly state that the channel count is the number of channels specified by the constructor. --- index.html | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/index.html b/index.html index 0522ded6e..a9be0b226 100644 --- a/index.html +++ b/index.html @@ -2860,6 +2860,50 @@

+
+

+ The OfflineAudioDestinationNode Interface +

+

+ This is an AudioNode representing the final audio + destination for an OfflineAudioContext. All + rendered audio will be routed to this node. There is only a single + OfflineAudioDestinationNode per OfflineAudioContext, provided + through the destination attribute of an OfflineAudioContext. +

+

+ An OfflineAudioDestinationNode is the equivalent of an + AudioDestinationNode for an OfflineAudioContext. The + output of this node is produced by summing + its input and captures the data that is returned by the startRendering + method. +

+

+ The channelCountMode cannnot be changed. An error of type + NotSupportedError MUST be thrown on any attempt to change the mode. +

+

+ The channelCount is set by the numberOfChannels + parameter to the OfflineAudioContext constructor. + After construction, the channel count cannot be changed. An error of + type NotSupportedError MUST be thrown on any attempt to change the + channel count. +

+ 
+      numberOfInputs  : 1
+      numberOfOutputs : 1
+
+      channelCountMode = "explicit"
+      channelInterpretation = "speakers";
+
+
+
+

The AudioParam Interface From 899a7f9ea08fa2118c6176459ef33b612610d0a1 Mon Sep 17 00:00:00 2001 From: Raymond Toy Date: Thu, 23 Jun 2016 15:19:25 -0700 Subject: [PATCH 2/4] Tidy. --- index.html | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/index.html b/index.html index a9be0b226..6bf9c551b 100644 --- a/index.html +++ b/index.html @@ -2866,21 +2866,21 @@

This is an AudioNode representing the final audio - destination for an OfflineAudioContext. All - rendered audio will be routed to this node. There is only a single - OfflineAudioDestinationNode per OfflineAudioContext, provided - through the destination attribute of an OfflineAudioContext. + destination for an OfflineAudioContext. All rendered + audio will be routed to this node. There is only a single + OfflineAudioDestinationNode per OfflineAudioContext, provided + through the destination attribute of an OfflineAudioContext.

An OfflineAudioDestinationNode is the equivalent of an - AudioDestinationNode for an OfflineAudioContext. The - output of this node is produced by summing - its input and captures the data that is returned by the startRendering + AudioDestinationNode for an OfflineAudioContext. The output of + this node is produced by summing its + input and captures the data that is returned by the startRendering method.

@@ -2901,8 +2901,8 @@

channelCountMode = "explicit" channelInterpretation = "speakers"; -
-
+

From e8324ccccd143094520310dfdac18927b1fa5533 Mon Sep 17 00:00:00 2001 From: Raymond Toy Date: Wed, 3 Aug 2016 12:58:21 -0700 Subject: [PATCH 3/4] Make OfflineAudioDestinationNode be a subclass of AudioDestinationNode. Add text say maxChannelCount is set to channelCount. --- index.html | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/index.html b/index.html index b4cf629a1..50f8853f6 100644 --- a/index.html +++ b/index.html @@ -2937,6 +2937,10 @@

type NotSupportedError MUST be thrown on any attempt to change the channel count.

+

+ The maxChannelCount is set to the same value as + channelCount. + 

       numberOfInputs  : 1
       numberOfOutputs : 1
@@ -2944,7 +2948,7 @@ 

       channelCountMode = "explicit"
       channelInterpretation = "speakers";
-

From 59d0efebb1557f7897532173c705025745ab8bb6 Mon Sep 17 00:00:00 2001 From: Raymond Toy Date: Tue, 6 Sep 2016 10:00:49 -0700 Subject: [PATCH 4/4] Run tidy. --- index.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/index.html b/index.html index 31db3f87f..d5494eafb 100644 --- a/index.html +++ b/index.html @@ -2969,7 +2969,8 @@

channelCountMode = "explicit" channelInterpretation = "speakers"; -