Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Rename gattserverdisconnected to gattserverdisconnect #363
From what I can see in several Web APIs such as WebUSB , Remote Playback and Presentation, they use
[ImplementedAs=ongattserverdisconnected] attribute EventHandler ongattserverdisconnect;
Right, that's a sensible argument. It breaks compatibility with anyone currently using
@RByers, do you have a sense of the right thing to do here? We probably shipped the wrong spelling of this event, but no other browsers have complained yet.
The main risk here is that it's almost certainly better to just live with the mis-spelling then to try to fix it but fail (due to web compat) to remove the old name and so get stuck having both indefinitely.
Nobody else has implemented this as far as you know, right? And usage is probably quite low? Do you already have a UseCounter for WebBluetooth which would provide an upper-bound on the risk here?
Assuming we have evidence that the usage is pretty low then I'd suggest just making a concrete plan to deprecate/remove the old name by a specific milestone and ship the new event at the same time as deprecating the old one. Hopefully you can get away with just firing both events during the transition period (rather than trying to do something complicated like we do for
Of course it's up to you guys whether the benefit of fixing the name is worth this hassle. But as long as the usage is low hopefully the hassle/pain is really small...