Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark sections that are more likely to change. #308

Merged
merged 6 commits into from Oct 21, 2016

Conversation

@jyasskin
Copy link
Member

commented Oct 7, 2016

These are all unimplemented, and haven't been thought through as well as
the rest of the spec.

Preview at https://api.csswg.org/bikeshed/?url=https://raw.githubusercontent.com/jyasskin/web-bluetooth-1/at-risk/index.bs#permission-api-integration.

@g-ortuno

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2016

What about advertisements?

@jyasskin

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2016

I think the advertisementreceived event is pretty stable even though we haven't implemented it; do you think it's likely to change?

@scheib

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2016

I'd err on the conservative side and mark it not stable if no implementation has started on it.

@jyasskin jyasskin force-pushed the jyasskin:at-risk branch from d70e032 to 50dbe43 Oct 10, 2016

@jyasskin

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2016

Ok, done. Do you think getIncludedService(), descriptors, referringDevice, acceptAllDevices, and Manufacturer/Service data are stable enough even though we haven't started implementing them?

@jyasskin jyasskin force-pushed the jyasskin:at-risk branch from 50dbe43 to d716345 Oct 15, 2016

@jyasskin

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2016

Ping. I also marked referringDevice as unstable, given our difficulties in getting the MAC address from Android.

@scheib

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2016

Thanks, I'd use the rule of "if no one has implemented it - then it is unstable". It is the most conservative thing to do, but also sends a clear message about what is easily malleable in the spec.

@jyasskin jyasskin force-pushed the jyasskin:at-risk branch from a7e8764 to 688142b Oct 19, 2016

@jyasskin

This comment has been minimized.

Copy link
Member Author

commented Oct 19, 2016

Done.

@jyasskin jyasskin force-pushed the jyasskin:at-risk branch 3 times, most recently from e54786c to 47c6377 Oct 19, 2016

jyasskin added 6 commits Oct 7, 2016
Mark sections that are more likely to change.
These are all unimplemented, and haven't been thought through as well as
the rest of the spec.
Mark referringDevice unstable.
This doesn't work as well as the other markings because of how
referringDevice is integrated into other sections.
Tweak the background image.
Make it bigger, blockier, and lighter.

@jyasskin jyasskin force-pushed the jyasskin:at-risk branch from 47c6377 to cba04f5 Oct 19, 2016

@scheib
scheib approved these changes Oct 21, 2016

@jyasskin jyasskin merged commit 3d98fff into WebBluetoothCG:master Oct 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jyasskin jyasskin deleted the jyasskin:at-risk branch Oct 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.