Added Bower #11

Merged
merged 8 commits into from Oct 3, 2014

Conversation

Projects
None yet
3 participants
@PxlBuzzard
Contributor

PxlBuzzard commented Sep 30, 2014

Giving wcDocker bower support has two primary benefits:

  1. No more storing jQuery and other dependencies in the repo. Instead run bower update in your local repo to download the necessary files.
  2. Other developers can include wcDocker in their bower.json file to get the same benefit of not storing wcDocker in their repo.

Note that you will need to run a bower register git://github.com/WebCabin/wcDocker.git after you accept the pull request to add wcDocker to the bower registry.

Edit: This patch will stop you from uploading this repo directly to http://docker.webcabin.org/ since not all the necessary files will be included in the repo. You might consider hooking into Travis, which will build and deploy a repo every time a commit is pushed (so you could have it upload the "built" version to your FTP server after each commit).

@Lochemage

This comment has been minimized.

Show comment
Hide comment
@Lochemage

Lochemage Oct 1, 2014

Contributor

I am interested in pulling in this change, but I will need to research bower first as I have never used it.

Contributor

Lochemage commented Oct 1, 2014

I am interested in pulling in this change, but I will need to research bower first as I have never used it.

@Lochemage

This comment has been minimized.

Show comment
Hide comment
@Lochemage

Lochemage Oct 1, 2014

Contributor

A question for you, the contextMenu library I use is a modified version specifically for wcDocker, it isn't the same as the public one by its original owner. It looks like you are linking to one on bower, is this their trunk or my modified version?

Contributor

Lochemage commented Oct 1, 2014

A question for you, the contextMenu library I use is a modified version specifically for wcDocker, it isn't the same as the public one by its original owner. It looks like you are linking to one on bower, is this their trunk or my modified version?

@PxlBuzzard

This comment has been minimized.

Show comment
Hide comment
@PxlBuzzard

PxlBuzzard Oct 3, 2014

Contributor

The switch to Bower does mean that I am using the unmodified version of jQuery-contextMenu. However, I worked with @danShumway to come up with a solution that does not rely on modification of the source file and instead handles the icons from docker.js. It's a pretty clean solution that should let you update the contextMenu plugin over time more easily.

Edit: We didn't build in support for the vanilla icon again, but it would be a simple addition.

Contributor

PxlBuzzard commented Oct 3, 2014

The switch to Bower does mean that I am using the unmodified version of jQuery-contextMenu. However, I worked with @danShumway to come up with a solution that does not rely on modification of the source file and instead handles the icons from docker.js. It's a pretty clean solution that should let you update the contextMenu plugin over time more easily.

Edit: We didn't build in support for the vanilla icon again, but it would be a simple addition.

@Lochemage

This comment has been minimized.

Show comment
Hide comment
@Lochemage

Lochemage Oct 3, 2014

Contributor

Alright, I have taken a look and am liking your solution, thank you! I would rather not use a modified version of someone else's library, so this may fix that issue. I can see a little bit more work will be needed before I am fully satisfied, but I will merge this request and then fix those issues next.

Contributor

Lochemage commented Oct 3, 2014

Alright, I have taken a look and am liking your solution, thank you! I would rather not use a modified version of someone else's library, so this may fix that issue. I can see a little bit more work will be needed before I am fully satisfied, but I will merge this request and then fix those issues next.

Lochemage added a commit that referenced this pull request Oct 3, 2014

Merge pull request #11 from PxlBuzzard/master
Added Bower, removed modified version of jQuery contextMenu.

@Lochemage Lochemage merged commit e25cdc0 into WebCabin:master Oct 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment