Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent browsers from moving/blinking on initial click of anchor link #9

Merged
merged 2 commits into from May 15, 2015

Conversation

ImBigWill
Copy link
Contributor

@ImBigWill ImBigWill commented Apr 25, 2015

This should fix the browser window from moving/blinking from side to side on initial click of anchor links before scrolling down the page. This happens in several browsers and is somewhat subtle, but after closer review seems like it's certainly the case. The solution seems to prevent that from happening. Tested on a handful of sites, including a default install with only this plugin active and a post with a couple of anchor tags as a sample.

@jtsternberg
Copy link
Contributor

@jtsternberg jtsternberg commented May 15, 2015

Thanks!

jtsternberg added a commit that referenced this issue May 15, 2015
Prevent browsers from moving/blinking on initial click of anchor link
@jtsternberg jtsternberg merged commit 1f8cc5c into WebDevStudios:master May 15, 2015
pluginmirror-worker pushed a commit to wp-plugins/hash-link-scroll-offset that referenced this issue May 15, 2015
@jtsternberg
Copy link
Contributor

@jtsternberg jtsternberg commented May 21, 2015

Hey Will, does this mean the url in the address bar is no longer updated when clicking a hash link? We definitely do not want to break that functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants