/
ChangeLog
17938 lines (13404 loc) · 717 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2012-12-20 Csaba Osztrogonác <ossy@webkit.org>
[Qt] EWS bots should call qmake always
https://bugs.webkit.org/show_bug.cgi?id=90049
Reviewed by Simon Hausmann.
* Scripts/webkitdirs.pm:
(buildQMakeProjects):
2012-12-20 Jochen Eisinger <jochen@chromium.org>
[chromium] fix stray printf in TestRunner's WebTestProxy
https://bugs.webkit.org/show_bug.cgi?id=105515
Reviewed by Ryosuke Niwa.
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::shouldInsertNode):
2012-12-20 Dominik Röttsches <dominik.rottsches@intel.com>
[WK2] WebAudio WKTR support
https://bugs.webkit.org/show_bug.cgi?id=95084
Reviewed by Kenneth Rohde Christiansen.
Implementing audio data dump support for WebKitTestRunner,
by adding the API to the IDL, enabling IPC for transferring
the audio data as bytebuffer and dumping it according
to run-webkit-tests script's expectations.
This enables audio testing on WebKit2 ports.
Based on initial wip-patch from Philippe Normand - thanks.
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
* WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
(WTR::TestRunner::setAudioData):
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
(TestRunner):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
(WTR::InjectedBundle::done):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
(WTR::InjectedBundle::setAudioResult):
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
* WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
(WTR::TestInvocation::dumpResults):
(WTR):
(WTR::TestInvocation::dumpAudio):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
* WebKitTestRunner/TestInvocation.h:
(TestInvocation):
2012-12-20 Alberto Garcia <agarcia@igalia.com>
[GTK] Count failed and timed out tests separately
https://bugs.webkit.org/show_bug.cgi?id=105448
Reviewed by Carlos Garcia Campos.
Display the number of tests that fail, time out and are skipped
separately in the buildbot page.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete):
(RunGtkAPITests.evaluateCommand):
(RunGtkAPITests.getText2):
* Scripts/run-gtk-tests:
(TestRunner.run_tests):
2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
PerfTest.parse_output does too much
https://bugs.webkit.org/show_bug.cgi?id=105391
Reviewed by Tony Chang.
Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
Also moved the code to output test results into PerfTest._run_with_driver.
* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.__init__): Added _description.
(PerfTest.description): Added.
(PerfTest._run_with_driver): Moved the code to output test description and test results.
(PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
(PerfTest.parse_output): Removed the code to output test results. Return test results and description
respectively. Also removed the code that allowed some tests to omit values since all tests report each
iteration now since r136492.
(PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
(ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
(ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
(PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
(MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
so that it's not string-concatenated with the next line.
(MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
(MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
2012-12-19 Alexis Menard <alexis@webkit.org>
Implement CSS parsing for CSS transitions unprefixed.
https://bugs.webkit.org/show_bug.cgi?id=104804
Reviewed by Dean Jackson.
Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to cover the work of unprefixing Transforms, Animations and
Transitions. It will let the possibility of each ports to turn it off
in their release branches until we're confident that these CSS
properties are ready to be unprefixed.
* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:
2012-12-19 Julien Chaffraix <jchaffraix@webkit.org>
2 clampTo unit tests are failing
https://bugs.webkit.org/show_bug.cgi?id=105253
Reviewed by Emil A Eklund.
Removed clampToUnsigned as it was actually testing exactly what
clampToUnsignedLong was doing. Also made clampToIntFloat more robust
to precision loss (fix suggested by Emil).
* TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2012-12-19 Thiago Marcos P. Santos <thiago.santos@intel.com>
[EFL] Move ImageDiff to the Tools directory root
https://bugs.webkit.org/show_bug.cgi?id=105305
Reviewed by Laszlo Gombos.
We previously moved this directory from the DRT directory to
efl/ImageDiff. The major reason for doing so was because ImageDiff does
not depend on DumpRenderTree but for legacy reasons was living inside the
DRT folder, even though it is needed when running pixel tests for WK2.
Now we are moving to Tool directory root as other ports agreed to do the same.
* CMakeLists.txt:
* ImageDiff/CMakeLists.txt: Added.
* ImageDiff/PlatformEfl.cmake: Added.
* ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
* efl/ImageDiff/CMakeLists.txt: Removed.
2012-12-19 Zeno Albisser <zeno@webkit.org>
[Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
https://bugs.webkit.org/show_bug.cgi?id=105309
The version number is only used as a part
of the library name on Linux.
Reviewed by Kenneth Rohde Christiansen.
* Scripts/webkitdirs.pm:
(builtDylibPathForName):
2012-12-19 Alberto Garcia <agarcia@igalia.com>
[GTK] Tests that time out are not considered as failures.
https://bugs.webkit.org/show_bug.cgi?id=105318
Reviewed by Martin Robinson.
Fix parsing of the GTK API tests log files.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete):
2012-12-18 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed, rolling out r138061.
https://bugs.webkit.org/show_bug.cgi?id=105396
Original patch:
http://trac.webkit.org/changeset/138061
https://bugs.webkit.org/show_bug.cgi?id=97359
It is crashing on Debug bots
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElement):
2012-12-18 Alice Liu <alice.liu@apple.com>
Test for https://bugs.webkit.org/show_bug.cgi?id=105106
Add SPI to WebKit1 WebFrame for hit testing
Reviewed by Dan Bernstein.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
* TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
(TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
Then hit-tests at three points, expecting to hit the two divs and body element.
2012-12-18 Alice Liu <alice.liu@apple.com>
Test for https://bugs.webkit.org/show_bug.cgi?id=105262
Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
Reviewed by Anders Carlsson.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
* TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
(TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
Loads html with a single div element. In an isolated world, creates a property on that node.
Also, in the standard world, creates a different property on that node. Then tests for 4 things:
- Existence of the isolated property in the isolated world.
- Existence of the standard property in the standard world.
- Non-existence of the isolated property in the standard world.
- Non-existence of the standard property in the isolated world.
2012-12-18 Simon Fraser <simon.fraser@apple.com>
Disable the SimplifyMarkup API test, wich asserts in debug builds.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
* TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
(TestWebKitAPI::TEST):
2012-12-18 Joseph Pecoraro <pecoraro@apple.com>
[Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
https://bugs.webkit.org/show_bug.cgi?id=104279
Reviewed by David Kilzer.
Add a build phase script that checks a framework's header files for
Platform.h and Compiler.h macros. Also add some tests for the script.
* Scripts/check-for-inappropriate-macros-in-external-headers: Added.
Script to be used in build phases to check for inappropriate macros in headers.
* Scripts/test-webkitruby: Added.
Script that can be used to run all webkitruby tests.
* Scripts/test-webkit-scripts:
Also run the ruby tests.
* Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
* Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
* Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
* Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
* Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
Tests for the new script.
2012-12-18 Dominic Mazzoni <dmazzoni@google.com>
AX: support clickPoint in DRT for chromium
https://bugs.webkit.org/show_bug.cgi?id=97359
Reviewed by Chris Fleizach.
Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
several more tests can pass.
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
(WebTestRunner):
(WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
(WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElement):
2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
Build fix after r138045.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
is not explicitly specified. The condition was backwards but never matched so we
always ran the test regardless of whether it's listed in the skipped list or not.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
2012-12-18 Emil A Eklund <eae@chromium.org>
TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
https://bugs.webkit.org/show_bug.cgi?id=105332
Reviewed by Levi Weintraub.
Create new test suite for LayoutUnit tests as the KURL tests are
of the incompatible TEST_F type.
* TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
(TestWebKitAPI):
(TestWebKitAPI::TEST_F):
2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
Running a skipped test with run-perf-tests could alert the user
https://bugs.webkit.org/show_bug.cgi?id=105219
Reviewed by Eric Seidel.
Force run skipped performance tests explicitly specified in the command line.
Also warn the user when the specified paths don't exist.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.relative_test_filename):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._collect_tests):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests_with_skipped_list_and_files):
2012-12-18 Yaron Friedman <yfriedman@chromium.org>
Chrome Android java output is too verbose
https://bugs.webkit.org/show_bug.cgi?id=105247
Reviewed by Tony Chang.
Pass -quiet to ant to suppress extraneous output.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
Consider removing --pause-before-testing option
https://bugs.webkit.org/show_bug.cgi?id=105248
Reviewed by Eric Seidel.
Remove --pause-before-testing option.
* Tools/Scripts/webkitpy/layout_tests/port/driver.py:
(DriverProxy.start): Removed.
* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.__init__):
(PerfTest.test_path): Renamed from path_or_url.
(PerfTest.run):
(PerfTest): Removed "driver" argument.
(PerfTest._run_with_driver):
(PerfTest.run_single):
(ChromiumStylePerfTest.__init__):
(PageLoadingPerfTest.__init__):
(PageLoadingPerfTest.run_single):
(PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
(ReplayPerfTest.__init__):
(ReplayPerfTest.prepare):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_memory_output):
(TestPageLoadingPerfTest.test_run_with_bad_output):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
(PerfTestsRunner._run_single_test): Removed "driver" argument.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(run_test):
(test_run_test_pause_before_testing): Removed.
2012-12-18 Alberto Garcia <agarcia@igalia.com>
[GTK] Tests that time out are not considered as failures.
https://bugs.webkit.org/show_bug.cgi?id=105318
Reviewed by Martin Robinson.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete):
Consider log lines that end with TIMEOUT as errors.
* Scripts/run-gtk-tests:
(TestRunner.run_tests):
Consider timeouts as failures when returning the number of failed
tests.
2012-12-18 Pravin D <pravin.d@samsung.com>
Unreviewed, adding secondary email.
* Scripts/webkitpy/common/config/committers.py:
2012-12-18 Pravin D <pravin.d@samsung.com>
Unreviewed, promoting myself to committer's list.
* Scripts/webkitpy/common/config/committers.py:
2012-12-18 Thiago Marcos P. Santos <thiago.santos@intel.com>
[EFL] ImageDiff does not build on WebKit2 only builds
https://bugs.webkit.org/show_bug.cgi?id=105288
Reviewed by Kenneth Rohde Christiansen.
Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
the folder with things which are EFL-specific.
ImageDiff will be built by default now regardless of WebKit API flavor
you choose.
* CMakeLists.txt:
* DumpRenderTree/efl/CMakeLists.txt:
* efl/ImageDiff/CMakeLists.txt: Added.
* efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
2012-12-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
[EFL][WK2] When creating new windows, use the opener's context
https://bugs.webkit.org/show_bug.cgi?id=105283
Reviewed by Laszlo Gombos.
Use the context of the opener if exists.
* MiniBrowser/efl/main.c:
(on_key_down):
(on_window_create):
(window_create):
(elm_main):
2012-12-18 Thiago Marcos P. Santos <thiago.santos@intel.com>
[EFL][WK2] Gardening of TestWebKitAPI tests
https://bugs.webkit.org/show_bug.cgi?id=105268
Reviewed by Kenneth Rohde Christiansen.
Some tests were marked as failing but are passing and the newly added
LayoutUnit should have it's own binary because it conflicts with the
fixture used by KURL and is failing on the bots because of that.
* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/PlatformEfl.cmake:
2012-12-18 Jochen Eisinger <jochen@chromium.org>
[chromium] move webintent related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=105164
Reviewed by Darin Fisher.
Also deleted the unused deliveredIntentFailure and
deliveredIntentResult methods.
* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebKit):
(WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest):
(WebTestRunner::WebTestDelegate::currentWebIntentRequest):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::registerIntentService):
(WebTestRunner::WebTestProxy::dispatchIntent):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::sendWebIntentResponse):
(WebTestRunner):
(WebTestRunner::TestRunner::deliverWebIntent):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setCurrentWebIntentRequest):
(WebViewHost::currentWebIntentRequest):
* DumpRenderTree/chromium/WebViewHost.h:
(WebKit):
(WebViewHost):
2012-12-18 Jochen Eisinger <jochen@chromium.org>
[chromium] move editing callback dumping to the WebTestProxy
https://bugs.webkit.org/show_bug.cgi?id=105013
Reviewed by Darin Fisher.
To decide whether or not to dump the editing callbacks, the WebTestProxy
needs to query the TestRunner. For this purpose, I introduce a
WebTestRunner class that just exposes the shouldDumpEditingCallbacks
method. In contrast to e.g. WebEventSender, the WebTestRunner is just
an interface, and it is not owned by the WebTestInterfaces, but the
embedder of the TestRunner library must provide it. This will change
once all TestRunner methods are in the library.
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
(DRTTestRunner::taskList):
(DRTTestRunner::WorkQueue::taskList):
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestRunner):
(WebTestInterfaces):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::shouldBeginEditing):
(WebTestRunner::WebTestProxy::shouldEndEditing):
(WebTestRunner::WebTestProxy::shouldInsertNode):
(WebTestRunner::WebTestProxy::shouldInsertText):
(WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
(WebTestRunner::WebTestProxy::shouldDeleteRange):
(WebTestRunner::WebTestProxy::shouldApplyStyle):
(WebTestRunner::WebTestProxy::didBeginEditing):
(WebTestRunner::WebTestProxy::didChangeSelection):
(WebTestRunner::WebTestProxy::didChangeContents):
(WebTestRunner::WebTestProxy::didEndEditing):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
(WebTestRunner):
(WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::~TestRunner):
(WebTestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpEditingCallbacks):
(WebTestRunner::TestRunner::dumpEditingCallbacks):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::Internal::testRunner):
(WebTestRunner::WebTestInterfaces::Internal::setTestRunner):
(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::Internal):
(WebTestRunner::WebTestInterfaces::testRunner):
(WebTestRunner):
(WebTestRunner::WebTestInterfaces::setTestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::shouldBeginEditing):
(WebTestRunner::WebTestProxyBase::shouldEndEditing):
(WebTestRunner::WebTestProxyBase::shouldInsertNode):
(WebTestRunner::WebTestProxyBase::shouldInsertText):
(WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
(WebTestRunner::WebTestProxyBase::shouldDeleteRange):
(WebTestRunner::WebTestProxyBase::shouldApplyStyle):
(WebTestRunner::WebTestProxyBase::didBeginEditing):
(WebTestRunner::WebTestProxyBase::didChangeSelection):
(WebTestRunner::WebTestProxyBase::didChangeContents):
(WebTestRunner::WebTestProxyBase::didEndEditing):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createNewWindow):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::shouldBeginEditing):
(WebViewHost::shouldEndEditing):
(WebViewHost::shouldInsertNode):
(WebViewHost::shouldInsertText):
(WebViewHost::shouldChangeSelectedRange):
(WebViewHost::shouldDeleteRange):
(WebViewHost::shouldApplyStyle):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
2012-12-17 Jochen Eisinger <jochen@chromium.org>
[chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=105154
Reviewed by Tony Chang.
If the settings are modified directly, the embedder can't keep track of
them and might accidentially override the changed settings.
* DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
(WebPreferences):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
(WebTestRunner):
(WebTestRunner::TestRunner::setMinimumTimerInterval):
(WebTestRunner::TestRunner::setTouchDragDropEnabled):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):
2012-12-17 Julien Chaffraix <jchaffraix@webkit.org>
Unreviewed unit test skipping.
Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.
* TestWebKitAPI/Tests/WTF/MathExtras.cpp:
(TestWebKitAPI):
(TestWebKitAPI::TEST):
2012-12-17 Dean Jackson <dino@apple.com>
Unreviewed. Add Silvia Pfeiffer to contributor list.
* Scripts/webkitpy/common/config/committers.py:
2012-12-17 Dirk Pranke <dpranke@chromium.org>
build.webkit.org - add more google windows bots
https://bugs.webkit.org/show_bug.cgi?id=105225
Reviewed by Eric Seidel.
Adds two more windows bots (google-windows-3, a builder, and
google-windows-4, a tester) for the Chromium configs.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2012-12-17 Eric Seidel <eric@webkit.org>
Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
https://bugs.webkit.org/show_bug.cgi?id=105217
Reviewed by Dirk Pranke.
Previously --profile would fail strangely if find_unused_filename returned None
(which would happen as soon as we had 100 report files).
Now we'll search through 1000 filenames before giving up (and assert if we failed to find one).
I also made some minor cleanups to the output of perf, and tried to make the
commands more self-documenting by using long-names for args.
* Scripts/webkitpy/common/system/profiler.py:
(SingleFileOutputProfiler.__init__):
(Perf.attach_to_pid):
(Perf.profile_after_exit):
2012-12-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r137198.
http://trac.webkit.org/changeset/137198
https://bugs.webkit.org/show_bug.cgi?id=105212
This patch is causing API behavior compatibility problems
(Requested by zdobersek on #webkit).
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(willSendRequestCallback):
2012-12-17 Elliott Sprehn <esprehn@chromium.org>
Unreviewed. Adding myself to committers list.
* Scripts/webkitpy/common/config/committers.py:
2012-12-17 Dirk Pranke <dpranke@chromium.org>
nrwt: shuffle code around for cleanup in run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=105078
Reviewed by Ojan Vafai.
This patch reorders functions so that run_webkit_tests can be
understood in a top-down matter better, and to make things slightly
more sensible when I merge manager.py into it.
Also, this adds tests for the actual main() routine, which had several
bugs get through testing a week or two ago.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(main):
(parse_args):
(_set_up_derived_options):
(run):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest):
(RunTest.test_no_http_tests):
(PortTest.disabled_test_mac_lion):
(MainTest):
(MainTest.test_exception_handling):
(MainTest.test_exception_handling.interrupting_run):
(MainTest.test_exception_handling.successful_run):
(MainTest.test_exception_handling.successful_run.FakeRunDetails):
(MainTest.test_exception_handling.exception_raising_run):
2012-12-17 Dirk Pranke <dpranke@chromium.org>
webkitpy: move --lint-test-files code into its own module
https://bugs.webkit.org/show_bug.cgi?id=105077
Reviewed by Eric Seidel.
It really didn't need to be in run_webkit_tests.py anymore.
This patch adds a new lint-test-expectations scripts to Tools/Scripts;
rwt --lint-test-files is still supported for backwards compatibility
for now.
* Scripts/lint-test-expectations: Added.
* Scripts/webkitpy/layout_tests/lint_test_expectations.py: Added.
(lint):
(main):
* Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: Added.
(FakePort):
(FakePort.__init__):
(FakePort.test_configuration):
(FakePort.expectations_dict):
(FakePort.skipped_layout_tests):
(FakePort.all_test_configurations):
(FakePort.configuration_specifier_macros):
(FakePort.get_option):
(FakeFactory):
(FakeFactory.__init__):
(FakeFactory.get):
(FakeFactory.all_port_names):
(LintTest):
(LintTest.test_all_configurations):
(LintTest.test_lint_test_files):
(LintTest.test_lint_test_files__errors):
(MainTest):
(MainTest.test_success):
(MainTest.test_success.interrupting_lint):
(MainTest.test_success.successful_lint):
(MainTest.test_success.exception_raising_lint):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(main):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(StreamTestingMixin.assertNotEmpty):
2012-12-17 Adam Klein <adamk@chromium.org>
build-webkit: rename --template-tag to --template-element to match ENABLE #define name
https://bugs.webkit.org/show_bug.cgi?id=105072
Reviewed by Laszlo Gombos.
* Scripts/webkitperl/FeatureList.pm:
2012-12-17 Julien Chaffraix <jchaffraix@webkit.org>
Add some unit testing for WTF::clampTo* functions
https://bugs.webkit.org/show_bug.cgi?id=105060
Reviewed by Emil A Eklund.
The new tests are targeted at clamping to int / unsigned and float as those are
the one explicitely exposed through more dedicated functions (like clampToInteger,
clampToPositiveInteger and clampToFloat).
* TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2012-12-17 Eric Seidel <eric@webkit.org>
rpt --profile --chromium-android throws exception
https://bugs.webkit.org/show_bug.cgi?id=105061
Reviewed by Daniel Bates.
Somehow popen(args) got turned into popen(*args) at some point,
which caused my new stringify code to fail when args was passed by name.
Fixed and tested.
* Scripts/webkitpy/common/system/executive.py:
(Executive._stringify_args):
(Executive):
(Executive.popen):
* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_popen_args):
2012-12-17 Mark Pilgrim <pilgrim@chromium.org>
Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=105054
Reviewed by Jochen Eisinger.
Part of a refactoring series; see tracking bug 82948.
* DumpRenderTree/chromium/NotificationPresenter.cpp:
(NotificationPresenter::show):
* DumpRenderTree/chromium/Task.cpp:
(postTask):
* DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
2012-12-17 Emil A Eklund <eae@chromium.org>
Clamp values in LayoutUnit::operator/ when SATURATED_LAYOUT_ARITHMETIC is enabled
https://bugs.webkit.org/show_bug.cgi?id=104955
Reviewed by Julien Chaffraix.
Add tests for LayoutUnit.
* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/ForwardingHeaders: Added.
* TestWebKitAPI/ForwardingHeaders/WebCore: Added.
* TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Added.
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
* TestWebKitAPI/TestWebKitAPI.gypi:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
2012-12-17 Jochen Eisinger <jochen@chromium.org>
[chromium] removed unused preferences from testRunner.overridePreference
https://bugs.webkit.org/show_bug.cgi?id=105169
Reviewed by Tony Chang.
Most notably this removes the code related to font family maps which is
now handled via window.internals.settings
* DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
(WebPreferences):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::overridePreference):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::applyTo):
2012-12-17 James Robinson <jamesr@chromium.org>
[chromium] Move creation of WebLayerTreeView to WebWidgetClient
https://bugs.webkit.org/show_bug.cgi?id=105071
Reviewed by Adrienne Walker.
Update WebViewHost for the new WebWidgetClient interface.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::initializeLayerTreeView):
(WebViewHost::layerTreeView):
(WebViewHost::~WebViewHost):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
2012-12-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
[EFL][WK2] window_create doesn't receive the url
https://bugs.webkit.org/show_bug.cgi?id=105184
Reviewed by Alexis Menard.
* MiniBrowser/efl/main.c: Use the url supplied to window_create
(on_window_create):
2012-12-17 Ilya Tikhonovsky <loislo@chromium.org>
Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
https://bugs.webkit.org/show_bug.cgi?id=105026
Reviewed by Yury Semikhatsky.
Old SFINAE test was replaced with new one based on this article:
http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
New test which covers this problem was added.
* TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2012-12-17 Anthony Scian <ascian@rim.com>
[Blackberry] Static code analysis warning fixes
https://bugs.webkit.org/show_bug.cgi?id=105129
Reviewed by Rob Buis.
Added null checks for fopen calls, no recovery attempted; access fault prevention only.
* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::createFile):
(BlackBerry::WebKit::DumpRenderTree::runTest):
2012-12-17 John Mellor <johnme@chromium.org>
Add Anton Vayvod and Tim Volodine as contributors in committers.py
https://bugs.webkit.org/show_bug.cgi?id=105025
Unreviewed. Adds two contributors to committers.py.
They are initially contributing to the Text Autosizing feature (master bug: 84186).
* Scripts/webkitpy/common/config/committers.py:
2012-12-17 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Unreviewed, add myself to committers.py.
* Scripts/webkitpy/common/config/committers.py:
2012-12-17 Oswald Buddenhagen <oswald.buddenhagen@digia.com>
[Qt] remove some unnecessary CONFIG additions
Reviewed by Simon Hausmann.
qt is already added by spec_pre.prf, warn_on and depend_includepath by
default_pre.prf.
* qmake/mkspecs/features/default_post.prf:
2012-12-17 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed, rolling out r137892.
http://trac.webkit.org/changeset/137892
https://bugs.webkit.org/show_bug.cgi?id=105026
it broke compilation on windows
* TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2012-12-14 Ilya Tikhonovsky <loislo@chromium.org>
Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
https://bugs.webkit.org/show_bug.cgi?id=105026
Reviewed by Yury Semikhatsky.
Old SFINAE test was replaced with new one based on this article:
http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
New test which covers this problem was added.
* TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2012-12-17 Oswald Buddenhagen <oswald.buddenhagen@digia.com>
[Qt] rely on automatic output directory setup
Reviewed by Simon Hausmann.
Now being a proper qt module (by virtue of having load(qt_build_config)
in .qmake.conf), webkit gets the path setup goodies for free.
This also fixes Makefile.api.Debug/Release trying to generate qrc_WebKit.cpp
at the same time, instead of the debug and release version ending up in different
directories as they should.
* qmake/mkspecs/features/default_pre.prf:
2012-12-17 Charles Wei <charles.wei@torchmobile.com.cn>
[BlackBerry] Need to re-enable video track
https://bugs.webkit.org/show_bug.cgi?id=105155
Reviewed by George Staikos.
Just enable Video Track for BlackBerry.
* Scripts/webkitperl/FeatureList.pm:
2012-12-17 János Badics <jbadics@inf.u-szeged.hu>
Unreviewed. Added myself to committers.py
* Scripts/webkitpy/common/config/committers.py:
2012-12-17 Jonathan Liu <net147@gmail.com>
Fix linking of libraries with -Wl,-whole-archive
https://bugs.webkit.org/show_bug.cgi?id=104436
Reviewed by Simon Hausmann.
If there is more than one library in LIBS linked with
-Wl,-whole-archive -l... -Wl,-no-whole-archive, qmake tries to
merge the duplicate flags in LIBS which causes linking to fail.
Add no_smart_library_merge to CONFIG to prevent the duplicate
flags from being removed when using -Wl,-whole-archive.
* qmake/mkspecs/features/functions.prf:
2012-12-16 Arvid Nilsson <anilsson@rim.com>
[BlackBerry] Adapt to new BlackBerry::Platform::TouchPoint API
https://bugs.webkit.org/show_bug.cgi?id=105143
RIM PR 171941
Reviewed by Rob Buis.
Internally reviewed by George Staikos.
Adapt to new method names and encapsulation of TouchPoint data members.
* DumpRenderTree/blackberry/EventSender.cpp:
(addTouchPointCallback):
(updateTouchPointCallback):
(touchEndCallback):
(releaseTouchPointCallback):
(sendTouchEvent):