Skip to content
Permalink
Browse files
ResourceRequestBase::isolatedCopy() fails to isolate copy the cachePa…
…rtition

https://bugs.webkit.org/show_bug.cgi?id=183059
<rdar://problem/37800202>

Reviewed by Youenn Fablet.

Update ResourceRequestBase::setAsIsolatedCopy() to call isolatedCopy() on the cachePartition as well,
given that it is a String and it would not be safe to send it to another thread otherwise.

* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setAsIsolatedCopy):


Canonical link: https://commits.webkit.org/198803@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cdumez committed Feb 22, 2018
1 parent bb900c6 commit 00a74c26850211aa3dc5a8102bb58e6f988ad658
Showing with 15 additions and 1 deletion.
  1. +14 −0 Source/WebCore/ChangeLog
  2. +1 −1 Source/WebCore/platform/network/ResourceRequestBase.cpp
@@ -1,3 +1,17 @@
2018-02-22 Chris Dumez <cdumez@apple.com>

ResourceRequestBase::isolatedCopy() fails to isolate copy the cachePartition
https://bugs.webkit.org/show_bug.cgi?id=183059
<rdar://problem/37800202>

Reviewed by Youenn Fablet.

Update ResourceRequestBase::setAsIsolatedCopy() to call isolatedCopy() on the cachePartition as well,
given that it is a String and it would not be safe to send it to another thread otherwise.

* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setAsIsolatedCopy):

2018-02-22 Chris Dumez <cdumez@apple.com>

ServiceWorkerContainer::startScriptFetchForJob() fails to isolate copy the registrationKey before passing it to the main thread
@@ -64,7 +64,7 @@ void ResourceRequestBase::setAsIsolatedCopy(const ResourceRequest& other)
setPriority(other.priority());
setRequester(other.requester());
setInitiatorIdentifier(other.initiatorIdentifier().isolatedCopy());
setCachePartition(other.cachePartition());
setCachePartition(other.cachePartition().isolatedCopy());

updateResourceRequest();
m_httpHeaderFields = other.httpHeaderFields().isolatedCopy();

0 comments on commit 00a74c2

Please sign in to comment.