Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Resource Load Statistics: Use WebProcessPool::allProcessPools() when …
…sending message to network process about partitioning

https://bugs.webkit.org/show_bug.cgi?id=172370
<rdar://problem/32288012>

Reviewed by Alex Christensen.

The existing test case
http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html
is currently failing and should start passing again with this patch.

* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains):


Canonical link: https://commits.webkit.org/189291@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@217158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
johnwilander committed May 19, 2017
1 parent 18d16fb commit 00e5aee
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
15 changes: 15 additions & 0 deletions Source/WebKit2/ChangeLog
@@ -1,3 +1,18 @@
2017-05-19 John Wilander <wilander@apple.com>

Resource Load Statistics: Use WebProcessPool::allProcessPools() when sending message to network process about partitioning
https://bugs.webkit.org/show_bug.cgi?id=172370
<rdar://problem/32288012>

Reviewed by Alex Christensen.

The existing test case
http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html
is currently failing and should start passing again with this patch.

* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains):

2017-05-19 Chris Dumez <cdumez@apple.com>

[WK2] Notify client when a process exceeds background CPU limit while in the foreground
Expand Down
2 changes: 1 addition & 1 deletion Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp
Expand Up @@ -1076,7 +1076,7 @@ void WebsiteDataStore::removeDataForTopPrivatelyControlledDomains(OptionSet<Webs
#if HAVE(CFNETWORK_STORAGE_PARTITIONING)
void WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains(const Vector<String>& domainsToRemove, const Vector<String>& domainsToAdd, bool clearFirst)
{
for (auto& processPool : processPools())
for (auto& processPool : WebProcessPool::allProcessPools())
processPool->sendToNetworkingProcess(Messages::NetworkProcess::ShouldPartitionCookiesForTopPrivatelyOwnedDomains(domainsToRemove, domainsToAdd, clearFirst));
}
#endif
Expand Down

0 comments on commit 00e5aee

Please sign in to comment.