Skip to content
Permalink
Browse files
Web Inspector: replace Canvas stack iteration with createScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=178980

Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, updated existing tests.

* inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::buildObjectForCanvas):
(WebCore::InspectorCanvas::buildAction):
(WebCore::iterateCallFrames): Deleted.

LayoutTests:

* inspector/canvas/create-context-2d-expected.txt:
* inspector/canvas/create-context-webgl-expected.txt:
* inspector/canvas/create-context-webgl2-expected.txt:
* inspector/canvas/create-context-webgpu-expected.txt:
* inspector/canvas/recording-2d-expected.txt:
* inspector/canvas/recording-webgl-expected.txt:
* inspector/canvas/recording-webgl-snapshots-expected.txt:


Canonical link: https://commits.webkit.org/195181@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dcrousso committed Oct 31, 2017
1 parent 16c87e9 commit 0159d30002c63c086ea0476c1052f9cb9551872d
Showing 10 changed files with 2,098 additions and 1,616 deletions.
@@ -1,3 +1,18 @@
2017-10-31 Devin Rousso <webkit@devinrousso.com>

Web Inspector: replace Canvas stack iteration with createScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=178980

Reviewed by Joseph Pecoraro.

* inspector/canvas/create-context-2d-expected.txt:
* inspector/canvas/create-context-webgl-expected.txt:
* inspector/canvas/create-context-webgl2-expected.txt:
* inspector/canvas/create-context-webgpu-expected.txt:
* inspector/canvas/recording-2d-expected.txt:
* inspector/canvas/recording-webgl-expected.txt:
* inspector/canvas/recording-webgl-snapshots-expected.txt:

2017-10-30 Chris Dumez <cdumez@apple.com>

Fire updatefound event after resolving the registration promise
@@ -7,32 +7,35 @@ PASS: CanvasManager should have no canvases.

-- Running test case: Canvas.CreateContext2D.Attached
PASS: Canvas context should be 2D.
0: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getContext - [native code]
1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Removed canvas has expected ID.

-- Running test case: Canvas.CreateContext2D.Detached
PASS: Canvas context should be 2D.
0: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:8:62
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getContext - [native code]
1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:8:62
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Removed canvas has expected ID.

-- Running test case: Canvas.CreateContext2D.CSSCanvas
Create CSS canvas from -webkit-canvas(css-canvas).
PASS: Canvas context should be 2D.
0: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:12:47
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getCSSCanvasContext - [native code]
1: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:12:47
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Canvas name should equal the identifier passed to -webkit-canvas.

@@ -7,32 +7,35 @@ PASS: CanvasManager should have no canvases.

-- Running test case: Canvas.CreateContextWebGL.Attached
PASS: Canvas context should be WebGL.
0: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getContext - [native code]
1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Removed canvas has expected ID.

-- Running test case: Canvas.CreateContextWebGL.Detached
PASS: Canvas context should be WebGL.
0: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:8:62
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getContext - [native code]
1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:8:62
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Removed canvas has expected ID.

-- Running test case: Canvas.CreateContextWebGL.CSSCanvas
Create CSS canvas from -webkit-canvas(css-canvas).
PASS: Canvas context should be WebGL.
0: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:12:47
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getCSSCanvasContext - [native code]
1: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:12:47
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Canvas name should equal the identifier passed to -webkit-canvas.

@@ -7,32 +7,35 @@ PASS: CanvasManager should have no canvases.

-- Running test case: Canvas.CreateContextWebGL2.Attached
PASS: Canvas context should be WebGL2.
0: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getContext - [native code]
1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Removed canvas has expected ID.

-- Running test case: Canvas.CreateContextWebGL2.Detached
PASS: Canvas context should be WebGL2.
0: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:8:62
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getContext - [native code]
1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:8:62
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Removed canvas has expected ID.

-- Running test case: Canvas.CreateContextWebGL2.CSSCanvas
Create CSS canvas from -webkit-canvas(css-canvas).
PASS: Canvas context should be WebGL2.
0: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:12:47
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getCSSCanvasContext - [native code]
1: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:12:47
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Canvas name should equal the identifier passed to -webkit-canvas.

@@ -7,32 +7,35 @@ PASS: CanvasManager should have no canvases.

-- Running test case: Canvas.CreateContextWebGPU.Attached
PASS: Canvas context should be WebGPU.
0: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getContext - [native code]
1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Removed canvas has expected ID.

-- Running test case: Canvas.CreateContextWebGPU.Detached
PASS: Canvas context should be WebGPU.
0: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:8:62
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getContext - [native code]
1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:8:62
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Removed canvas has expected ID.

-- Running test case: Canvas.CreateContextWebGPU.CSSCanvas
Create CSS canvas from -webkit-canvas(css-canvas).
PASS: Canvas context should be WebGPU.
0: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:12:47
1: Global Code - [program code]
2: evaluateWithScopeExtension - [native code]
3: _evaluateOn - [native code]
4: _evaluateAndWrap - [native code]
0: getCSSCanvasContext - [native code]
1: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:12:47
2: Global Code - [program code]
3: evaluateWithScopeExtension - [native code]
4: _evaluateOn - [native code]
5: _evaluateAndWrap - [native code]

PASS: Canvas name should equal the identifier passed to -webkit-canvas.

0 comments on commit 0159d30

Please sign in to comment.