Skip to content
Permalink
Browse files
[MSE][GStreamer] Soundcloud serves MP4 audio with empty tfdt boxes
https://bugs.webkit.org/show_bug.cgi?id=191419

Patch by Philippe Normand <pnormand@igalia.com> on 2021-06-18
Reviewed by Michael Catanzaro.

Source/WebCore:

When MSE is used the player receives broken audio fragments, perhaps because the server
expects the client to repair them. Not much we can do about this on GStreamer side though,
so behave as a Chrome UserAgent and then MSE is not used, the player receives an MP3 stream.

* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):

Tools:

* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST): Add a test for the soundcloud quirk.

Canonical link: https://commits.webkit.org/238959@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
philn authored and webkit-commit-queue committed Jun 18, 2021
1 parent 615b387 commit 01a2c0cff141ebcefa186b07113c2fb3eeb19856
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 0 deletions.
@@ -1,3 +1,17 @@
2021-06-18 Philippe Normand <pnormand@igalia.com>

[MSE][GStreamer] Soundcloud serves MP4 audio with empty tfdt boxes
https://bugs.webkit.org/show_bug.cgi?id=191419

Reviewed by Michael Catanzaro.

When MSE is used the player receives broken audio fragments, perhaps because the server
expects the client to repair them. Not much we can do about this on GStreamer side though,
so behave as a Chrome UserAgent and then MSE is not used, the player receives an MP3 stream.

* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):

2021-06-18 Carlos Alberto Lopez Perez <clopez@igalia.com>

[LFC][WPE] Build failure with GCC 8.x
@@ -62,6 +62,10 @@ static bool urlRequiresChromeBrowser(const String& domain, const String& baseDom
if (domain == "docs.google.com")
return true;

// soundcloud.com serves broken MSE audio fragments with WebKitGTK's standard user agent.
if (baseDomain == "soundcloud.com")
return true;

return false;
}

@@ -1,3 +1,13 @@
2021-06-18 Philippe Normand <pnormand@igalia.com>

[MSE][GStreamer] Soundcloud serves MP4 audio with empty tfdt boxes
https://bugs.webkit.org/show_bug.cgi?id=191419

Reviewed by Michael Catanzaro.

* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST): Add a test for the soundcloud quirk.

2021-06-17 Mark Lam <mark.lam@apple.com>

Define MacroAssemblerARM64E::numberOfPACBits based on OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH).
@@ -86,6 +86,7 @@ TEST(UserAgentTest, Quirks)
assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
assertUserAgentForURLHasChromeBrowserQuirk("http://auth.mayohr.com/");
assertUserAgentForURLHasChromeBrowserQuirk("http://bankofamerica.com/");
assertUserAgentForURLHasChromeBrowserQuirk("http://soundcloud.com/");

assertUserAgentForURLHasFirefoxBrowserQuirk("http://bugzilla.redhat.com/");

0 comments on commit 01a2c0c

Please sign in to comment.