Skip to content
Permalink
Browse files
Address some review comments on bug 133408
https://bugs.webkit.org/show_bug.cgi?id=133410

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKBackForwardListItem.h:
* UIProcess/API/Cocoa/WKUIDelegate.h:


Canonical link: https://commits.webkit.org/151482@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
geoffreygaren committed Jun 2, 2014
1 parent 00c61e5 commit 01a9fb0fc91e4093f3cdcee28a3387019993cecf
Showing 3 changed files with 20 additions and 7 deletions.
@@ -1,3 +1,13 @@
2014-06-02 Geoffrey Garen <ggaren@apple.com>

Address some review comments on bug 133408
https://bugs.webkit.org/show_bug.cgi?id=133410

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKBackForwardListItem.h:
* UIProcess/API/Cocoa/WKUIDelegate.h:

2014-06-02 Dan Bernstein <mitz@apple.com>

[Cocoa] -[WKWebView activeURL] is unused
@@ -29,7 +29,7 @@

#import <Foundation/Foundation.h>

/*! A WKBackForwardListItem object represents a previously visited webpage in the back-forward list of a web view.
/*! A WKBackForwardListItem object represents a webpage in the back-forward list of a web view.
*/
WK_CLASS_AVAILABLE(10_10, 8_0)
@interface WKBackForwardListItem : NSObject
@@ -59,8 +59,9 @@
call.
@param completionHandler The completion handler to call after the alert
panel has been dismissed.
@discussion Clients should visually indicate that this panel comes from
JavaScript initiated by the specified frame.
@discussion For user security, your app should call attention to the fact
that a specific website controls the content in this panel. A simple forumla
for identifying the controlling website is frame.request.URL.host.
The panel should have a single OK button.
*/
- (void)webView:(WKWebView *)webView runJavaScriptAlertPanelWithMessage:(NSString *)message initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)())completionHandler;
@@ -72,8 +73,9 @@
@param completionHandler The completion handler to call after the confirm
panel has been dismissed. Pass YES if the user chose OK, NO if the user
chose Cancel.
@discussion Clients should visually indicate that this panel comes from
JavaScript initiated by the specified frame.
@discussion For user security, your app should call attention to the fact
that a specific website controls the content in this panel. A simple forumla
for identifying the controlling website is frame.request.URL.host.
The panel should have two buttons, such as OK and Cancel.
*/
- (void)webView:(WKWebView *)webView runJavaScriptConfirmPanelWithMessage:(NSString *)message initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(BOOL result))completionHandler;
@@ -86,8 +88,9 @@
@param completionHandler The completion handler to call after the text
input panel has been dismissed. Pass the entered text if the user chose
OK, otherwise nil.
@discussion Clients should visually indicate that this panel comes from
JavaScript initiated by the specified frame.
@discussion For user security, your app should call attention to the fact
that a specific website controls the content in this panel. A simple forumla
for identifying the controlling website is frame.request.URL.host.
The panel should have two buttons, such as OK and Cancel, and a field in
which to enter text.
*/

0 comments on commit 01a9fb0

Please sign in to comment.