Skip to content
Permalink
Browse files
Web Inspector: CSSStyleDeclarationTextEditor fails to update if compu…
…ted properties changed from empty to non-empty

https://bugs.webkit.org/show_bug.cgi?id=139610

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-12-15
Reviewed by Timothy Hatcher.

The CSSStyleDeclarationTextEditor for Computed Style Properties always has
empty DOMNodeStyles text. However we would not reset contents if properties
changed and the actualy content was empty. So once empty, we could never
recover. In fact, we should always refresh for Computed Styles.

* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._propertiesChanged):

Canonical link: https://commits.webkit.org/157552@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JosephPecoraro authored and webkit-commit-queue committed Dec 16, 2014
1 parent 15fd7da commit 021d7e098bf6903aa7e89ba0bd7f7a0ab8967096
Showing with 16 additions and 1 deletion.
  1. +15 −0 Source/WebInspectorUI/ChangeLog
  2. +1 −1 Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js
@@ -1,3 +1,18 @@
2014-12-15 Joseph Pecoraro <pecoraro@apple.com>

Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty
https://bugs.webkit.org/show_bug.cgi?id=139610

Reviewed by Timothy Hatcher.

The CSSStyleDeclarationTextEditor for Computed Style Properties always has
empty DOMNodeStyles text. However we would not reset contents if properties
changed and the actualy content was empty. So once empty, we could never
recover. In fact, we should always refresh for Computed Styles.

* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._propertiesChanged):

2014-12-08 Joseph Pecoraro <pecoraro@apple.com>

Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported
@@ -726,7 +726,7 @@ WebInspector.CSSStyleDeclarationTextEditor.prototype = {
return;

// Reset the content if the text is different and we are not focused.
if (!this.focused && this._style.text !== this._formattedContent()) {
if (!this.focused && (!this._style.text || this._style.text !== this._formattedContent())) {
this._resetContent();
return;
}

0 comments on commit 021d7e0

Please sign in to comment.