Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Web Inspector: Canvas2D Profiling: highlight expensive context comman…
…ds in the captured command log

https://bugs.webkit.org/show_bug.cgi?id=178302
<rdar://problem/33158849>

Reviewed by Brian Burg.

Source/JavaScriptCore:

* inspector/protocol/Recording.json:
Add `duration` to each Frame that represents the total time of all the recorded actions.

Source/WebCore:

No new tests, updated existing tests.

* inspector/InspectorCanvas.h:
* inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::finalizeFrame):
(WebCore::InspectorCanvas::markNewFrame): Deleted.

* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):

Source/WebInspectorUI:

* UserInterface/Models/RecordingFrame.js:
(WI.RecordingFrame):
(WI.RecordingFrame.fromPayload):
(WI.RecordingFrame.prototype.get duration):
(WI.RecordingFrame.prototype.toJSON):

* UserInterface/Views/RecordingNavigationSidebarPanel.js:
(WI.RecordingNavigationSidebarPanel.prototype.set recording):
* UserInterface/Views/RecordingNavigationSidebarPanel.css:
(.sidebar > .panel.navigation.recording > .content > .tree-outline .item.folder-icon > .status):

LayoutTests:

* inspector/canvas/recording-2d-expected.txt:
* inspector/canvas/recording-webgl-expected.txt:
* inspector/canvas/recording-webgl-snapshots-expected.txt:
* inspector/canvas/resources/recording-utilities.js:
(TestPage.registerInitializer):
* inspector/model/recording-expected.txt:
* inspector/model/recording.html:


Canonical link: https://commits.webkit.org/195327@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dcrousso committed Nov 3, 2017
1 parent 1cea986 commit 034e216
Show file tree
Hide file tree
Showing 17 changed files with 332 additions and 228 deletions.
16 changes: 16 additions & 0 deletions LayoutTests/ChangeLog
@@ -1,3 +1,19 @@
2017-11-03 Devin Rousso <webkit@devinrousso.com>

Web Inspector: Canvas2D Profiling: highlight expensive context commands in the captured command log
https://bugs.webkit.org/show_bug.cgi?id=178302
<rdar://problem/33158849>

Reviewed by Brian Burg.

* inspector/canvas/recording-2d-expected.txt:
* inspector/canvas/recording-webgl-expected.txt:
* inspector/canvas/recording-webgl-snapshots-expected.txt:
* inspector/canvas/resources/recording-utilities.js:
(TestPage.registerInitializer):
* inspector/model/recording-expected.txt:
* inspector/model/recording.html:

2017-11-02 Devin Rousso <webkit@devinrousso.com>

Web Inspector: Canvas Tab: show supported GL extensions for selected canvas
Expand Down

0 comments on commit 034e216

Please sign in to comment.