Skip to content
Permalink
Browse files
REGRESSION(r289154) [GSTREAMER] webrtc/vp8-then-h264.html is crashing…
… after SDK update to fdo 21.08 and Gstreamer 1.20

https://bugs.webkit.org/show_bug.cgi?id=237872

Patch by Philippe Normand <pnormand@igalia.com> on 2022-03-20
Reviewed by Adrian Perez de Castro.

* platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:
(WebCore::VP8Decoder::Create): Fix typo in decoder factory test.


Canonical link: https://commits.webkit.org/248650@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
philn authored and webkit-commit-queue committed Mar 20, 2022
1 parent 3441b7d commit 035c30dcd8241ed77ace891114175bf1da9c5a0b
Showing 2 changed files with 11 additions and 1 deletion.
@@ -1,3 +1,13 @@
2022-03-20 Philippe Normand <pnormand@igalia.com>

REGRESSION(r289154) [GSTREAMER] webrtc/vp8-then-h264.html is crashing after SDK update to fdo 21.08 and Gstreamer 1.20
https://bugs.webkit.org/show_bug.cgi?id=237872

Reviewed by Adrian Perez de Castro.

* platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:
(WebCore::VP8Decoder::Create): Fix typo in decoder factory test.

2022-03-20 Zan Dobersek <zdobersek@igalia.com>

[WPE][GStreamer] media playback broken
@@ -367,7 +367,7 @@ class VP8Decoder : public GStreamerVideoDecoder {
static std::unique_ptr<webrtc::VideoDecoder> Create()
{
auto factory = GstDecoderFactory("video/x-vp8");
if (!factory) {
if (factory) {
const auto* factoryName = GST_OBJECT_NAME(GST_OBJECT(factory.get()));
if (!g_strcmp0(factoryName, "vp8dec") || !g_strcmp0(factoryName, "vp8alphadecodebin")) {
GST_INFO("Our best GStreamer VP8 decoder is vp8dec, better use the one from LibWebRTC");

0 comments on commit 035c30d

Please sign in to comment.