Skip to content
Permalink
Browse files
Grab the lock in FTL::Thunks::keyForSlowPathCallThunk
https://bugs.webkit.org/show_bug.cgi?id=227988
<rdar://problem/80627901>

Reviewed by Mark Lam.

JSTests:

* stress/thunks-hash-map-should-grab-lock.js: Added.

Source/JavaScriptCore:

Both FTL::Thunks::keyForSlowPathCallThunk and FTL::Thunks::getSlowPathCallThunk
both touch the thunks hash map. In r278030, when I added the lock, I grabbed it
in getSlowPathCallThunk, but forgot to also grab it in keyForSlowPathCallThunk.

* ftl/FTLThunks.h:
(JSC::FTL::Thunks::keyForSlowPathCallThunk):


Canonical link: https://commits.webkit.org/239750@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Saam Barati committed Jul 16, 2021
1 parent d2adc84 commit 04841c1b83eb7faa15d10ddd57d075b378a26a60
Showing with 507 additions and 0 deletions.
  1. +10 −0 JSTests/ChangeLog
  2. +481 −0 JSTests/stress/thunks-hash-map-should-grab-lock.js
  3. +15 −0 Source/JavaScriptCore/ChangeLog
  4. +1 −0 Source/JavaScriptCore/ftl/FTLThunks.h
@@ -1,3 +1,13 @@
2021-07-16 Saam Barati <sbarati@apple.com>

Grab the lock in FTL::Thunks::keyForSlowPathCallThunk
https://bugs.webkit.org/show_bug.cgi?id=227988
<rdar://problem/80627901>

Reviewed by Mark Lam.

* stress/thunks-hash-map-should-grab-lock.js: Added.

2021-07-16 Yusuke Suzuki <ysuzuki@apple.com>

[JSC] RegExp::dumpToStream must not ref Strings since it is called concurrently

0 comments on commit 04841c1

Please sign in to comment.