Skip to content
Permalink
Browse files
[GTK] fast/events/page-visibility-transition-test.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=114789

Reviewed by Darin Adler.

Tools:

* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::setHidden): Map and unmap the WebView when the harness
requests visibility changes.

LayoutTests:

* platform/gtk/TestExpectations: Unskip failing tests.

Canonical link: https://commits.webkit.org/162883@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@184060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
mrobinson committed May 11, 2015
1 parent eb6dc79 commit 0621a29d5963361fa645d7e90741129740a5f4a6
Showing with 27 additions and 8 deletions.
  1. +9 −0 LayoutTests/ChangeLog
  2. +0 −6 LayoutTests/platform/gtk/TestExpectations
  3. +11 −0 Tools/ChangeLog
  4. +7 −2 Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp
@@ -1,3 +1,12 @@
2015-05-10 Martin Robinson <mrobinson@igalia.com>

[GTK] fast/events/page-visibility-transition-test.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=114789

Reviewed by Darin Adler.

* platform/gtk/TestExpectations: Unskip failing tests.

2015-05-10 Chris Fleizach <cfleizach@apple.com>

AX: Don't expose elements as data tables just because they use display: table
@@ -2270,12 +2270,6 @@ webkit.org/b/144765 fast/events/touch/touch-inside-iframe-scrolled.html [ Failur
webkit.org/b/144765 fast/events/touch/touch-slider-no-js-touch-listener.html [ Failure ]
webkit.org/b/144765 fast/events/touch/touch-inside-iframe.html [ Timeout ]

# Need support for adjusting page visibility in the test harness.
webkit.org/b/114789 fast/events/page-visibility-iframe-delete-test.html [ Timeout ]
webkit.org/b/114789 fast/events/page-visibility-iframe-move-test.html [ Timeout ]
webkit.org/b/114789 fast/events/page-visibility-iframe-propagation-test.html [ Timeout ]
webkit.org/b/114789 fast/events/page-visibility-transition-test.html [ Timeout ]

webkit.org/b/144763 fast/events/scroll-in-scaled-page-with-overflow-hidden.html

#////////////////////////////////////////////////////////////////////////////////////////
@@ -1,3 +1,14 @@
2015-05-10 Martin Robinson <mrobinson@igalia.com>

[GTK] fast/events/page-visibility-transition-test.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=114789

Reviewed by Darin Adler.

* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::setHidden): Map and unmap the WebView when the harness
requests visibility changes.

2015-05-10 Csaba Osztrogonác <ossy@webkit.org>

[EFL] Fix install-dependencies on Ubuntu 14.10/15.04
@@ -95,9 +95,14 @@ void TestController::platformInitializeContext()
{
}

void TestController::setHidden(bool)
void TestController::setHidden(bool hidden)
{
// FIXME: Need to implement this to test visibilityState.
if (!m_mainWebView)
return;
if (hidden)
gtk_widget_unmap(GTK_WIDGET(m_mainWebView->platformView()));
else
gtk_widget_map(GTK_WIDGET(m_mainWebView->platformView()));
}

void TestController::runModal(PlatformWebView*)

0 comments on commit 0621a29

Please sign in to comment.