Skip to content
Permalink
Browse files
REGRESSION (r191613): Web Inspector: Can't type spaces when editing D…
…OM nodes

https://bugs.webkit.org/show_bug.cgi?id=152173

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-12-12
Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):
Disable the keyboard shortcuts when they are created. They will be
enabled when the panel is shown / hidden. It doesn't really make sense
that these are on the sidebar panel instead of the tab, but things
will be changing in Timelines soon anyways so just fix this now.

Canonical link: https://commits.webkit.org/170335@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@194009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JosephPecoraro authored and webkit-commit-queue committed Dec 12, 2015
1 parent 67802bb commit 062d34b86cbd14fff4b1887917763ed50e7ab1cf
Showing 2 changed files with 16 additions and 0 deletions.
@@ -1,3 +1,17 @@
2015-12-12 Joseph Pecoraro <pecoraro@apple.com>

REGRESSION (r191613): Web Inspector: Can't type spaces when editing DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=152173

Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):
Disable the keyboard shortcuts when they are created. They will be
enabled when the panel is shown / hidden. It doesn't really make sense
that these are on the sidebar panel instead of the tab, but things
will be changing in Timelines soon anyways so just fix this now.

2015-12-12 Nikita Vasilyev <nvasilyev@apple.com>

Web Inspector: "Selected Element" should use sans-serif font, not monospace
@@ -175,9 +175,11 @@ WebInspector.TimelineSidebarPanel = class TimelineSidebarPanel extends WebInspec

this._toggleRecordingShortcut = new WebInspector.KeyboardShortcut(null, WebInspector.KeyboardShortcut.Key.Space, this._toggleRecordingOnSpacebar.bind(this));
this._toggleRecordingShortcut.implicitlyPreventsDefault = false;
this._toggleRecordingShortcut.disabled = true;

this._toggleNewRecordingShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Shift, WebInspector.KeyboardShortcut.Key.Space, this._toggleNewRecordingOnSpacebar.bind(this));
this._toggleNewRecordingShortcut.implicitlyPreventsDefault = false;
this._toggleNewRecordingShortcut.disabled = true;
}

// Static

0 comments on commit 062d34b

Please sign in to comment.