Skip to content
Permalink
Browse files
WebPageGroup::setPreferences should set the preferences on all pages …
…in the group

https://bugs.webkit.org/show_bug.cgi?id=128383

Reviewed by Alexey Proskuryakov.

* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::setPreferences):

Canonical link: https://commits.webkit.org/146407@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Anders Carlsson committed Feb 7, 2014
1 parent eee33cf commit 0667e8883d1c03e7ccf104d728897a70cf460412
Showing with 16 additions and 0 deletions.
  1. +10 −0 Source/WebKit2/ChangeLog
  2. +6 −0 Source/WebKit2/UIProcess/WebPageGroup.cpp
@@ -1,3 +1,13 @@
2014-02-07 Anders Carlsson <andersca@apple.com>

WebPageGroup::setPreferences should set the preferences on all pages in the group
https://bugs.webkit.org/show_bug.cgi?id=128383

Reviewed by Alexey Proskuryakov.

* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::setPreferences):

2014-02-07 Dan Bernstein <mitz@apple.com>

[Cocoa] WKRemoteObjectInterface doesn’t support aribtrary argument classes
@@ -105,11 +105,17 @@ void WebPageGroup::setPreferences(WebPreferences* preferences)
if (!m_preferences) {
m_preferences = preferences;
m_preferences->addPageGroup(this);

for (auto& webPageProxy : m_pages)
webPageProxy->setPreferences(*m_preferences);
} else {
m_preferences->removePageGroup(this);
m_preferences = preferences;
m_preferences->addPageGroup(this);

for (auto& webPageProxy : m_pages)
webPageProxy->setPreferences(*m_preferences);

preferencesDidChange();
}
}

0 comments on commit 0667e88

Please sign in to comment.