Skip to content
Permalink
Browse files
Address flaky test case scroll-into-view-and-show-validation-message.…
…html when run using WK1

https://bugs.webkit.org/show_bug.cgi?id=240875

Reviewed by Wenson Hsieh.

Address failing test case fast/forms/scroll-into-view-and-show-validation-message.html
when run using WK1. This test only fails when running WK1 and only when run
in parallel.

* LayoutTests/fast/forms/textarea-scrolled-endline-caret.html:
* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/250998@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
stwrt committed May 26, 2022
1 parent ff11be4 commit 06b95d543fe8d1c9817cd3d7dbea3c15b8b09055
Showing 2 changed files with 20 additions and 12 deletions.
@@ -1,9 +1,13 @@
<!DOCTYPE html>
<html>
<head>
<script src="../../resources/ui-helper.js"></script>
<script>
function test()
async function test()
{
if (window.testRunner)
testRunner.dumpAsText();

var ta = document.getElementById('ta')
var res = document.getElementById('res');

@@ -13,19 +17,23 @@
ta.blur();

ta.focus();

// click
if (window.eventSender) {

testRunner.waitUntilDone();
requestAnimationFrame(() => {
eventSender.mouseMoveTo(90, 20);
eventSender.mouseDown();
eventSender.mouseUp();
if (ta.selectionEnd == 17)
res.innerHTML = "Test Succeeded";
else
res.innerHTML = "Test Failed: caret is at " + ta.selectionEnd;
testRunner.notifyDone();
});
await UIHelper.renderingUpdate();

eventSender.mouseMoveTo(90, 20);
eventSender.mouseDown();
eventSender.mouseUp();

if (ta.selectionEnd == 17)
res.innerHTML = "Test Succeeded";
else
res.innerHTML = "Test Failed: caret is at " + ta.selectionEnd;

testRunner.notifyDone();
} else {
res.innerHTML = "Test can't run without event sender (part of DumpRenderTree). "
+ "To test manually, click at the middle of the line marked 9 and check that the caret appears after the 9.";
@@ -47,3 +55,4 @@
10</textarea>
<div id="res"></div>
</body>
</html>
@@ -1844,4 +1844,3 @@ webkit.org/b/231298 accessibility/mac/selection-boundary-userinfo.html [ Failure
webkit.org/b/232630 fast/forms/autofocus-opera-003.html [ Failure ]

webkit.org/b/240841 fast/forms/scroll-into-view-and-show-validation-message.html [ Pass Failure ]
webkit.org/b/240841 fast/forms/textarea-scrolled-endline-caret.html [ Pass Failure ]

0 comments on commit 06b95d5

Please sign in to comment.