Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Unprefix font-size: -webkit-xxx-large
https://bugs.webkit.org/show_bug.cgi?id=246574 rdar://101207950 Reviewed by Myles C. Maxfield. xxx-large is now part of the spec and matches what we've implemented: https://drafts.csswg.org/css-fonts-4/#valdef-font-size-absolute-size Make -webkit-xxx-large an alias of xxx-large at parse-time, so it's easy to remove later on. * LayoutTests/editing/style/push-down-font-styles-mac-expected.txt: * LayoutTests/editing/style/push-down-font-styles-mac.html: * LayoutTests/editing/style/push-down-font-styles-win-expected.txt: * LayoutTests/editing/style/push-down-font-styles-win.html: * LayoutTests/fast/css/font-size-webkit-xxx-large-expected.html: Added. * LayoutTests/fast/css/font-size-webkit-xxx-large.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-xxx-large.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-valid-expected.txt: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::consumeFontSize): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeFontSizeRaw): * Source/WebCore/editing/EditingStyle.cpp: (WebCore::legacyFontSizeFromCSSValue): * Source/WebCore/html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::cssValueFromFontSizeNumber): * Source/WebCore/platform/graphics/FontCascadeDescription.h: (WebCore::FontCascadeDescription::keywordSizeAsIdentifier const): (WebCore::FontCascadeDescription::setKeywordSizeFromIdentifier): * Source/WebCore/style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyValueFontSize): * Source/WebCore/style/StyleFontSizeFunctions.h: * Source/WebCore/style/StyleResolveForFontRaw.cpp: (WebCore::Style::resolveForFontRaw): * Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js: Canonical link: https://commits.webkit.org/255602@main
- Loading branch information
Showing
19 changed files
with
61 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<!DOCTYPE html> | ||
<html> | ||
<p>Computed style is: 48px</p> | ||
<p>Specified style is: xxx-large</p> | ||
<span id="rendered" style="font-size: xxx-large">Rendering result</span> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<!DOCTYPE html> | ||
<html> | ||
<title>-webkit-xxx-large is an alias of xxx-large</title> | ||
<p>Computed style is: <span id="computed"></span></p> | ||
<p>Specified style is: <span id="specified"></span></p> | ||
<span id="rendered" style="font-size: -webkit-xxx-large">Rendering result</span> | ||
<script> | ||
computed.textContent = getComputedStyle(rendered).fontSize; | ||
specified.textContent = rendered.style.fontSize; | ||
</script> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters