Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
[Apple Pay] Deprecate
enabled
in favor of available
in ApplePaySh…
…ippingContactEditingMode https://bugs.webkit.org/show_bug.cgi?id=259659 rdar://113159800 Reviewed by Wenson Hsieh. In iOS 17, PassKit is deprecating PKShippingContactEditingModeEnabled in favor of PKShippingContactEditingModeAvailable in the PKShippingContactEditingMode enumeration. Reference: https://developer.apple.com/documentation/passkit/pkshippingcontacteditingmode/pkshippingcontacteditingmodeenabled?language=objc Given our intention to reflect the PassKit public API in the Apple Pay JS API, we should follow suit and perform a similar deprecation. We do so by introducing `available`, the preferred enumeration value, and logging a console warning whenever a PaymentSession is inititated with a PaymentRequest containing the deprecated `shippingContactEditingMode` value. * LayoutTests/http/tests/paymentrequest/paymentrequest-shippingContactEditingMode.https.html: * Source/WebCore/Modules/applepay/ApplePayShippingContactEditingMode.h: * Source/WebCore/Modules/applepay/ApplePayShippingContactEditingMode.idl: * Source/WebCore/Modules/applepay/PaymentCoordinator.cpp: (WebCore::PaymentCoordinator::beginPaymentSession): * Source/WebKit/Shared/ApplePay/PaymentSetupConfiguration.mm: Drive-by fix of a mismatched namespace. * Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::toPKShippingContactEditingMode): Canonical link: https://commits.webkit.org/266493@main
- Loading branch information
Showing
6 changed files
with
27 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters