Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Incorrect inline box decoration position when content box is vertical…
…ly shifted (text-underline-position/vertical edition) https://bugs.webkit.org/show_bug.cgi?id=245316 <rdar://problem/100071411> Reviewed by Simon Fraser. This is a follow-up on 254554@main (https://commits.webkit.org/254554@main) where an inline box with vertical border/padding produces incorrect underline position. This patch addresses both the vertical (ideographic baseline) and the "text-underline-position: under" cases where we use the inline box's logical height to compute the underline offset. * LayoutTests/fast/inline/text-decoration-underline-inline-box-offset-expected.html: Added. * LayoutTests/fast/inline/text-decoration-underline-inline-box-offset.html: Added. * Source/WebCore/style/InlineTextBoxStyle.cpp: use the inline box's content box to compute the underline offset. (WebCore::underlineOffsetForTextBoxPainting): Canonical link: https://commits.webkit.org/254593@main
- Loading branch information
Showing 3 changed files with 39 additions and 1 deletion.