Skip to content
Permalink
Browse files
JavaScriptCore files should not be included relatively
https://bugs.webkit.org/show_bug.cgi?id=182452

Reviewed by Keith Miller.

* API/JSCallbackConstructor.h:
* CMakeLists.txt:
* disassembler/ARM64Disassembler.cpp:
* disassembler/ARMv7Disassembler.cpp:
* heap/LockDuringMarking.h:
* inspector/InjectedScriptBase.h:
* inspector/InjectedScriptHost.h:
* inspector/JavaScriptCallFrame.h:
* inspector/ScriptArguments.h:
* inspector/ScriptDebugListener.h:
* inspector/ScriptDebugServer.h:
* inspector/agents/InspectorAgent.h:
* inspector/agents/InspectorConsoleAgent.h:
* inspector/agents/InspectorDebuggerAgent.h:
* inspector/agents/InspectorHeapAgent.h:
* inspector/agents/InspectorRuntimeAgent.h:
* inspector/agents/InspectorScriptProfilerAgent.h:
* runtime/RegExp.h:


Canonical link: https://commits.webkit.org/198286@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
donny-dont committed Feb 5, 2018
1 parent a3f6937 commit 091ada7804de1c48a39e83fb779b3ba465985e43
@@ -26,8 +26,8 @@
#ifndef JSCallbackConstructor_h
#define JSCallbackConstructor_h

#include "JSDestructibleObject.h"
#include "JSObjectRef.h"
#include "runtime/JSDestructibleObject.h"

namespace JSC {

@@ -25,8 +25,9 @@ set(JavaScriptCore_PRIVATE_INCLUDE_DIRECTORIES
"${JAVASCRIPTCORE_DIR}/bytecompiler"
"${JAVASCRIPTCORE_DIR}/dfg"
"${JAVASCRIPTCORE_DIR}/disassembler"
"${JAVASCRIPTCORE_DIR}/disassembler/udis86"
"${JAVASCRIPTCORE_DIR}/disassembler/ARM64"
"${JAVASCRIPTCORE_DIR}/disassembler/ARMv7"
"${JAVASCRIPTCORE_DIR}/disassembler/udis86"
"${JAVASCRIPTCORE_DIR}/domjit"
"${JAVASCRIPTCORE_DIR}/ftl"
"${JAVASCRIPTCORE_DIR}/heap"
@@ -1,3 +1,29 @@
2018-02-05 Don Olmstead <don.olmstead@sony.com>

JavaScriptCore files should not be included relatively
https://bugs.webkit.org/show_bug.cgi?id=182452

Reviewed by Keith Miller.

* API/JSCallbackConstructor.h:
* CMakeLists.txt:
* disassembler/ARM64Disassembler.cpp:
* disassembler/ARMv7Disassembler.cpp:
* heap/LockDuringMarking.h:
* inspector/InjectedScriptBase.h:
* inspector/InjectedScriptHost.h:
* inspector/JavaScriptCallFrame.h:
* inspector/ScriptArguments.h:
* inspector/ScriptDebugListener.h:
* inspector/ScriptDebugServer.h:
* inspector/agents/InspectorAgent.h:
* inspector/agents/InspectorConsoleAgent.h:
* inspector/agents/InspectorDebuggerAgent.h:
* inspector/agents/InspectorHeapAgent.h:
* inspector/agents/InspectorRuntimeAgent.h:
* inspector/agents/InspectorScriptProfilerAgent.h:
* runtime/RegExp.h:

2018-02-05 Commit Queue <commit-queue@webkit.org>

Unreviewed, rolling out r228012.
@@ -28,7 +28,7 @@

#if USE(ARM64_DISASSEMBLER)

#include "ARM64/A64DOpcode.h"
#include "A64DOpcode.h"
#include "MacroAssemblerCodeRef.h"

namespace JSC {
@@ -28,7 +28,7 @@

#if USE(ARMV7_DISASSEMBLER)

#include "ARMv7/ARMv7DOpcode.h"
#include "ARMv7DOpcode.h"
#include "MacroAssemblerCodeRef.h"

namespace JSC {
@@ -25,7 +25,7 @@

#pragma once

#include <heap/Heap.h>
#include "Heap.h"
#include <wtf/Locker.h>

namespace JSC {
@@ -33,7 +33,7 @@

#include "InspectorEnvironment.h"
#include "InspectorProtocolObjects.h"
#include "bindings/ScriptObject.h"
#include "ScriptObject.h"
#include <wtf/Forward.h>
#include <wtf/RefPtr.h>

@@ -26,7 +26,7 @@
#pragma once

#include "JSCJSValueInlines.h"
#include "inspector/PerGlobalObjectWrapperWorld.h"
#include "PerGlobalObjectWrapperWorld.h"
#include <wtf/RefCounted.h>

namespace Inspector {
@@ -25,8 +25,8 @@

#pragma once

#include "DebuggerCallFrame.h"
#include "JSCJSValueInlines.h"
#include "debugger/DebuggerCallFrame.h"
#include <wtf/Forward.h>
#include <wtf/RefCounted.h>
#include <wtf/text/TextPosition.h>
@@ -31,7 +31,7 @@

#pragma once

#include <heap/Strong.h>
#include "Strong.h"
#include <wtf/Forward.h>
#include <wtf/RefCounted.h>
#include <wtf/Vector.h>
@@ -29,8 +29,8 @@

#pragma once

#include "debugger/Debugger.h"
#include "parser/SourceProvider.h"
#include "Debugger.h"
#include "SourceProvider.h"
#include <wtf/text/WTFString.h>

namespace Inspector {
@@ -29,9 +29,9 @@

#pragma once

#include "Debugger.h"
#include "ScriptBreakpoint.h"
#include "ScriptDebugListener.h"
#include "debugger/Debugger.h"
#include <wtf/HashMap.h>
#include <wtf/HashSet.h>
#include <wtf/text/WTFString.h>
@@ -29,9 +29,9 @@

#pragma once

#include "InspectorAgentBase.h"
#include "InspectorBackendDispatchers.h"
#include "InspectorFrontendDispatchers.h"
#include "inspector/InspectorAgentBase.h"
#include <wtf/Forward.h>
#include <wtf/Vector.h>

@@ -25,9 +25,9 @@

#pragma once

#include "InspectorAgentBase.h"
#include "InspectorBackendDispatchers.h"
#include "InspectorFrontendDispatchers.h"
#include "inspector/InspectorAgentBase.h"
#include <wtf/Forward.h>
#include <wtf/HashMap.h>
#include <wtf/Noncopyable.h>
@@ -29,13 +29,13 @@

#pragma once

#include "Debugger.h"
#include "InspectorAgentBase.h"
#include "InspectorBackendDispatchers.h"
#include "InspectorFrontendDispatchers.h"
#include "bindings/ScriptValue.h"
#include "debugger/Debugger.h"
#include "inspector/InspectorAgentBase.h"
#include "inspector/ScriptBreakpoint.h"
#include "inspector/ScriptDebugListener.h"
#include "ScriptBreakpoint.h"
#include "ScriptDebugListener.h"
#include "ScriptValue.h"
#include <wtf/Forward.h>
#include <wtf/HashMap.h>
#include <wtf/Noncopyable.h>
@@ -25,10 +25,10 @@

#pragma once

#include "HeapObserver.h"
#include "InspectorAgentBase.h"
#include "InspectorBackendDispatchers.h"
#include "InspectorFrontendDispatchers.h"
#include "heap/HeapObserver.h"
#include "inspector/InspectorAgentBase.h"
#include <wtf/Forward.h>
#include <wtf/Noncopyable.h>

@@ -31,8 +31,8 @@

#pragma once

#include "InspectorAgentBase.h"
#include "InspectorBackendDispatchers.h"
#include "inspector/InspectorAgentBase.h"
#include <wtf/Forward.h>
#include <wtf/Noncopyable.h>

@@ -26,9 +26,9 @@
#pragma once

#include "Debugger.h"
#include "InspectorAgentBase.h"
#include "InspectorBackendDispatchers.h"
#include "InspectorFrontendDispatchers.h"
#include "inspector/InspectorAgentBase.h"
#include <wtf/Noncopyable.h>

namespace JSC {
@@ -25,12 +25,12 @@
#include "MatchResult.h"
#include "RegExpKey.h"
#include "Structure.h"
#include "yarr/Yarr.h"
#include "Yarr.h"
#include <wtf/Forward.h>
#include <wtf/text/WTFString.h>

#if ENABLE(YARR_JIT)
#include "yarr/YarrJIT.h"
#include "YarrJIT.h"
#endif

namespace JSC {

0 comments on commit 091ada7

Please sign in to comment.