Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Do not install the VMTraps signal handler if Options::useJIT=false.
https://bugs.webkit.org/show_bug.cgi?id=212543 <rdar://problem/63772519> Reviewed by Keith Miller. VMTraps is only needed for JITted code. Hence, if the JIT is disabled, we should set Options::usePollingTraps() to true to indicate that we won't be using VMTraps. With this change, we no longer install any signal handling machinery if Options::useJIT() is false. Because we may still disable the JIT even if useJIT() is true (due to failure to allocate JIT memory or a number of other factors), we will also add a check of VM::canUseJIT() in initializeThreading(), and disable useJIT() if needed. Of course, this also means we need to call Options::recomputeDependentOptions() to make other options consistent with useJIT() being false. * runtime/InitializeThreading.cpp: (JSC::initializeThreading): * runtime/Options.cpp: (JSC::disableAllJITOptions): (JSC::Options::recomputeDependentOptions): (JSC::recomputeDependentOptions): Deleted. * runtime/Options.h: * runtime/VMTraps.cpp: (JSC::VMTraps::initializeSignals): * tools/SigillCrashAnalyzer.cpp: (JSC::SigillCrashAnalyzer::instance): Canonical link: https://commits.webkit.org/225993@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
6 changed files
with
61 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters