Web Inspector: REGRESSION(?): Sources: WebSocket status not shown whe…

…n organized By Path https://bugs.webkit.org/show_bug.cgi?id=218679 Reviewed by Brian Burg. * UserInterface/Views/SourcesNavigationSidebarPanel.js: (WI.SourcesNavigationSidebarPanel.prototype._addResource): Make sure to use `WI.WebSocketResourceTreeElement` for `WI.WebSocketResource`. Canonical link: https://commits.webkit.org/231528@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Nov 12, 2020 · 0b66d69 · 0b66d69
1 parent 7da1e7d
commit 0b66d69
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
@@ -1,3 +1,14 @@
+2020-11-12  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(?): Sources: WebSocket status not shown when organized By Path
+        https://bugs.webkit.org/show_bug.cgi?id=218679
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/SourcesNavigationSidebarPanel.js:
+        (WI.SourcesNavigationSidebarPanel.prototype._addResource):
+        Make sure to use `WI.WebSocketResourceTreeElement` for `WI.WebSocketResource`.
+
 2020-11-11  John Wilander  <wilander@apple.com>
 
         PCM: Change from ad-click-attribution to private-click-measurement (in all forms, including .well-known URL)

diff --git a/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js
@@ -1080,8 +1080,10 @@ WI.SourcesNavigationSidebarPanel = class SourcesNavigationSidebarPanel extends W
             let resourceTreeElement = null;
             if (resource instanceof WI.CSSStyleSheet)
                 resourceTreeElement = new WI.CSSStyleSheetTreeElement(resource);
-            else
-                resourceTreeElement = new WI.ResourceTreeElement(resource, resource, {allowDirectoryAsName: true, hideOrigin: true});
+            else {
+                let constructor = resource.type === WI.Resource.Type.WebSocket ? WI.WebSocketResourceTreeElement : WI.ResourceTreeElement;
+                resourceTreeElement = new constructor(resource, resource, {allowDirectoryAsName: true, hideOrigin: true});
+            }
 
             let index = insertionIndexForObjectInListSortedByFunction(resourceTreeElement, parentTreeElement.children, this._boundCompareTreeElements);
             parentTreeElement.insertChild(resourceTreeElement, index);