Skip to content
Permalink
Browse files
[iOS] No message displayed when Parental content filter blocked load
https://bugs.webkit.org/show_bug.cgi?id=240724

Reviewed by Geoffrey Garen.

The request to unblock a load after it has being blocked by the Parental content filter on iOS needs to be
performed in the UI process, since it may show UI. This path does not set the blocked error description on
the content filter like we do in the other path, which is addressed in this patch. This is a regression
from moving the content filtering to the Network process.

* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::contentFilterDidBlock):

Canonical link: https://commits.webkit.org/250931@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
pvollan committed May 24, 2022
1 parent b926cd4 commit 0bc59c2265138c228122fbcb74c4729f82070167
Showing 1 changed file with 3 additions and 2 deletions.
@@ -1830,9 +1830,10 @@ WebCore::ResourceError NetworkResourceLoader::contentFilterDidBlock(WebCore::Con
m_unblockHandler = unblockHandler;
m_unblockRequestDeniedScript = unblockRequestDeniedScript;

if (unblockHandler.needsUIProcess())
if (unblockHandler.needsUIProcess()) {
m_contentFilter->setBlockedError(error);
m_contentFilter->handleProvisionalLoadFailure(error);
else {
} else {
unblockHandler.requestUnblockAsync([this, protectedThis = Ref { *this }](bool unblocked) mutable {
m_unblockHandler.setUnblockedAfterRequest(unblocked);

0 comments on commit 0bc59c2

Please sign in to comment.