Skip to content
Permalink
Browse files
Web Inspector: REGRESSION: TreeElement or Table row selected using th…
…e keyboard should always be revealed

https://bugs.webkit.org/show_bug.cgi?id=194918
<rdar://problem/48289314>

Reviewed by Devin Rousso.

* UserInterface/Views/Table.js:
(WI.Table.prototype.selectionControllerSelectionDidChange):

* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._treeKeyDown):


Canonical link: https://commits.webkit.org/209381@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
LuckyKobold committed Feb 25, 2019
1 parent 7a4a1c6 commit 0bfbf87b78056c21b9ca08bcbe795e7b4cc0b00e
Showing 3 changed files with 20 additions and 4 deletions.
@@ -1,3 +1,17 @@
2019-02-25 Matt Baker <mattbaker@apple.com>

Web Inspector: REGRESSION: TreeElement or Table row selected using the keyboard should always be revealed
https://bugs.webkit.org/show_bug.cgi?id=194918
<rdar://problem/48289314>

Reviewed by Devin Rousso.

* UserInterface/Views/Table.js:
(WI.Table.prototype.selectionControllerSelectionDidChange):

* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._treeKeyDown):

2019-02-25 Devin Rousso <drousso@apple.com>

Web Inspector: [META] Merge Resources and Debugger into a single Sources tab
@@ -619,10 +619,9 @@ WI.Table = class Table extends WI.View
row.classList.toggle("selected", true);
}

if (selectedItems.size === 1) {
let rowIndex = this._indexForRepresentedObject(selectedItems.firstValue);
if (!this._isRowVisible(rowIndex))
this.revealRow(rowIndex);
if (this._selectionController.lastSelectedItem) {
let rowIndex = this._indexForRepresentedObject(this._selectionController.lastSelectedItem);
this.revealRow(rowIndex);
}

if (this._delegate.tableSelectionDidChange)
@@ -661,6 +661,9 @@ WI.TreeOutline = class TreeOutline extends WI.Object
this._itemWasSelectedByUser = true;
handled = this._selectionController.handleKeyDown(event);
this._itemWasSelectedByUser = false;

if (handled)
nextSelectedElement = this.selectedTreeElement;
}

if (nextSelectedElement) {

0 comments on commit 0bfbf87

Please sign in to comment.