Skip to content
Permalink
Browse files
Flaky Test: platform/mac/editing/deleting/deletionUI-single-instance.…
…html

https://bugs.webkit.org/show_bug.cgi?id=114181

Reviewed by Ryosuke Niwa.

Editor survives navigations, and so did DeleteButtonController. But the state it holds
is document specific (like nodes in the old document).

* editing/Editor.cpp: (WebCore::Editor::clear): Replace DeleteButtonController.


Canonical link: https://commits.webkit.org/138770@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aproskuryakov committed Sep 6, 2013
1 parent c4c991f commit 0c28da6094d2635d1a97dbed82d0d84a026307d3
Showing 2 changed files with 16 additions and 0 deletions.
@@ -1,3 +1,15 @@
2013-09-05 Alexey Proskuryakov <ap@apple.com>

Flaky Test: platform/mac/editing/deleting/deletionUI-single-instance.html
https://bugs.webkit.org/show_bug.cgi?id=114181

Reviewed by Ryosuke Niwa.

Editor survives navigations, and so did DeleteButtonController. But the state it holds
is document specific (like nodes in the old document).

* editing/Editor.cpp: (WebCore::Editor::clear): Replace DeleteButtonController.

2013-09-05 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Generate toFooElement() functions from tagname data.
@@ -921,6 +921,10 @@ void Editor::clear()
m_customCompositionUnderlines.clear();
m_shouldStyleWithCSS = false;
m_defaultParagraphSeparator = EditorParagraphSeparatorIsDiv;

#if ENABLE(DELETION_UI)
m_deleteButtonController = adoptPtr(new DeleteButtonController(&m_frame));
#endif
}

bool Editor::insertText(const String& text, Event* triggeringEvent)

0 comments on commit 0c28da6

Please sign in to comment.