Skip to content
Permalink
Browse files
Unreviewed, rolling out r225656.
The test has been a flaky timout since being added.

Reverted changeset:

"WebAssembly: sending module to iframe fails"
https://bugs.webkit.org/show_bug.cgi?id=179263
https://trac.webkit.org/changeset/225656

Canonical link: https://commits.webkit.org/196934@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
huskyroll committed Dec 21, 2017
1 parent 01d163c commit 0cd6c2009ce41cadaebdba13d88c2f5b4bbb429d
Showing 18 changed files with 28 additions and 178 deletions.
@@ -1,3 +1,15 @@
2017-12-20 Matt Lewis <jlewis3@apple.com>

Unreviewed, rolling out r225656.

The test has been a flaky timout since being added.

Reverted changeset:

"WebAssembly: sending module to iframe fails"
https://bugs.webkit.org/show_bug.cgi?id=179263
https://trac.webkit.org/changeset/225656

2017-12-20 Matt Lewis <jlewis3@apple.com>

Unreviewed, rolling out r226155.
@@ -52,9 +52,6 @@ http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-about-blank-ifr
http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-external-script.html [ Failure ]
http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-subframe.html [ Failure ]
http/tests/security/contentSecurityPolicy/WebAssembly-blocked.html [ Failure ]
wasm/iframe-postmessage.html [ Skip ]
wasm/iframe-parent-postmessage.html [ Skip ]
wasm/window-postmessage.html [ Skip ]

# WebGL tests which need triaging https://bugs.webkit.org/b/174100
webgl/1.0.2/conformance/uniforms/uniform-default-values.html [ Failure ]
@@ -3673,9 +3673,6 @@ workers/wasm-hashset.html [ Skip ]
workers/wasm-long-compile-many.html [ Skip ]
workers/wasm-long-compile.html [ Skip ]
workers/wasm-mem-post-message.html [ Skip ]
wasm/iframe-postmessage.html [ Skip ]
wasm/iframe-parent-postmessage.html [ Skip ]
wasm/window-postmessage.html [ Skip ]

# Animated image throttling behaves differently on WK1.
svg/animations/animated-svg-image-outside-viewport-paused.html [ Skip ]

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

@@ -1,6 +1,6 @@
<html>
<head>
<script src="../resources/wasm-builder.js"></script>
<script src="./wasm-resources/builder.js"></script>
<script src="../resources/js-test-pre.js"></script>
</head>
<body>
File renamed without changes.
@@ -1,3 +1,15 @@
2017-12-20 Matt Lewis <jlewis3@apple.com>

Unreviewed, rolling out r225656.

The test has been a flaky timout since being added.

Reverted changeset:

"WebAssembly: sending module to iframe fails"
https://bugs.webkit.org/show_bug.cgi?id=179263
https://trac.webkit.org/changeset/225656

2017-12-20 Don Olmstead <don.olmstead@sony.com>

[Win] Use WCharStringExtras functions in WebCore
@@ -1066,7 +1066,7 @@ class CloneSerializer : CloneBase {

#if ENABLE(WEBASSEMBLY)
if (JSWebAssemblyModule* module = jsDynamicDowncast<JSWebAssemblyModule*>(vm, obj)) {
if (m_context != SerializationContext::WorkerPostMessage && m_context != SerializationContext::WindowPostMessage)
if (m_context != SerializationContext::WorkerPostMessage)
return false;

uint32_t index = m_wasmModules.size();
@@ -51,7 +51,7 @@ class SharedBuffer;
enum class SerializationReturnCode;

enum class SerializationErrorMode { NonThrowing, Throwing };
enum class SerializationContext { Default, WorkerPostMessage, WindowPostMessage };
enum class SerializationContext { Default, WorkerPostMessage };

using ArrayBufferContentsArray = Vector<JSC::ArrayBufferContents>;
#if ENABLE(WEBASSEMBLY)
@@ -927,7 +927,7 @@ ExceptionOr<void> DOMWindow::postMessage(JSC::ExecState& state, DOMWindow& incum
}

Vector<RefPtr<MessagePort>> ports;
auto message = SerializedScriptValue::create(state, messageValue, WTFMove(transfer), ports, SerializationContext::WindowPostMessage);
auto message = SerializedScriptValue::create(state, messageValue, WTFMove(transfer), ports);
if (message.hasException())
return message.releaseException();

0 comments on commit 0cd6c20

Please sign in to comment.