Skip to content
Permalink
Browse files
Web Inspector: Clicking on the expand object arrow should always expa…
…nd an object

https://bugs.webkit.org/show_bug.cgi?id=139382

Patch by Nikita Vasilyev <nvasilyev@apple.com> on 2014-12-15
Reviewed by Joseph Pecoraro.

* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._click): Deleted.
stopPropagation was preventing the object expansion from happening as expecting.

Canonical link: https://commits.webkit.org/157561@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
NV authored and webkit-commit-queue committed Dec 16, 2014
1 parent 12337f0 commit 0d7c3034a730cccc2a07a9d427cb35f4e68b87f7
Showing with 12 additions and 11 deletions.
  1. +12 −0 Source/WebInspectorUI/ChangeLog
  2. +0 −11 Source/WebInspectorUI/UserInterface/Views/LogContentView.js
@@ -1,3 +1,15 @@
2014-12-15 Nikita Vasilyev <nvasilyev@apple.com>

Web Inspector: Clicking on the expand object arrow should always expand an object
https://bugs.webkit.org/show_bug.cgi?id=139382

Reviewed by Joseph Pecoraro.

* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._click): Deleted.
stopPropagation was preventing the object expansion from happening as expecting.

2014-12-15 Joseph Pecoraro <pecoraro@apple.com>

Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty
@@ -40,7 +40,6 @@ WebInspector.LogContentView = function(representedObject)
this.messagesElement.addEventListener("focus", this._didFocus.bind(this));
this.messagesElement.addEventListener("blur", this._didBlur.bind(this));
this.messagesElement.addEventListener("keydown", this._keyDown.bind(this));
this.messagesElement.addEventListener("click", this._click.bind(this), true);
this.messagesElement.addEventListener("dragstart", this._ondragstart.bind(this), true);
this.element.appendChild(this.messagesElement);

@@ -411,7 +410,6 @@ WebInspector.LogContentView.prototype = {
var message = wrapper.messageElement;
if (this._targetInMessageCanBeSelected(event.target, message)) {
var sameWrapper = wrapper === this._mouseDownWrapper;
this._mouseInteractionShouldPreventClickPropagation = !this._isMessageSelected(message);
this._updateMessagesSelection(message, sameWrapper ? this._mouseDownCommandKey : false, sameWrapper ? this._mouseDownShiftKey : true);
}
} else if (!selection.isCollapsed) {
@@ -431,15 +429,6 @@ WebInspector.LogContentView.prototype = {
delete this._mouseDownCommandKey;
},

_click: function(event)
{
if (!this._mouseInteractionShouldPreventClickPropagation)
return;

event.stopPropagation();
delete this._mouseInteractionShouldPreventClickPropagation;
},

_ondragstart: function(event)
{
if (event.target.enclosingNodeOrSelfWithClass(WebInspector.DOMTreeOutline.StyleClassName)) {

0 comments on commit 0d7c303

Please sign in to comment.