Skip to content
Permalink
Browse files
2009-11-21 Daniel Bates <dbates@webkit.org>
        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31647

        Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.

        No functionality was changed. So, no new tests.

        * dom/KeyboardEvent.cpp:
        (WebCore::KeyboardEvent::~KeyboardEvent):
        * dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr.
        (WebCore::KeyboardEvent::keyEvent):

Canonical link: https://commits.webkit.org/42714@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
eseidel committed Nov 21, 2009
1 parent ced3e8f commit 0e9fd8aa82049cea2080f63f8d4c5296b7543be3
Showing with 17 additions and 3 deletions.
  1. +15 −0 WebCore/ChangeLog
  2. +0 −1 WebCore/dom/KeyboardEvent.cpp
  3. +2 −2 WebCore/dom/KeyboardEvent.h
@@ -1,3 +1,18 @@
2009-11-21 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31647

Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.

No functionality was changed. So, no new tests.

* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::~KeyboardEvent):
* dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr.
(WebCore::KeyboardEvent::keyEvent):

2009-11-20 Chris Fleizach <cfleizach@apple.com>

Reviewed by Beth Dakin.
@@ -80,7 +80,6 @@ KeyboardEvent::KeyboardEvent(const AtomicString& eventType, bool canBubble, bool

KeyboardEvent::~KeyboardEvent()
{
delete m_keyEvent;
}

void KeyboardEvent::initKeyboardEvent(const AtomicString& type, bool canBubble, bool cancelable, AbstractView* view,
@@ -79,7 +79,7 @@ namespace WebCore {

bool altGraphKey() const { return m_altGraphKey; }

const PlatformKeyboardEvent* keyEvent() const { return m_keyEvent; }
const PlatformKeyboardEvent* keyEvent() const { return m_keyEvent.get(); }

int keyCode() const; // key code for keydown and keyup, character for keypress
int charCode() const; // character code for keypress, 0 for keydown and keyup
@@ -99,7 +99,7 @@ namespace WebCore {
const String& keyIdentifier, unsigned keyLocation,
bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, bool altGraphKey);

PlatformKeyboardEvent* m_keyEvent;
OwnPtr<PlatformKeyboardEvent> m_keyEvent;
String m_keyIdentifier;
unsigned m_keyLocation;
bool m_altGraphKey : 1;

0 comments on commit 0e9fd8a

Please sign in to comment.