Skip to content
Permalink
Browse files
Finish migration to MathML WPT tests
https://bugs.webkit.org/show_bug.cgi?id=183628

Patch by Frederic Wang <fwang@igalia.com> on 2018-03-14
Reviewed by Manuel Rego Casasnovas.

In r225162, the MathML tests from the WPT repository were imported. They were intended to
replace the ones in imported/mathml-in-html5 but the migration was not fully possible. The
main issue was that many MathML tests use Web fonts to test the use of OpenType parameters
but document.fonts.ready is unreliable in WebKit (bug 174030). A workaround was implemented
in WPT ( web-platform-tests/wpt#10025 ) so this commit finishes
the migration. We update the WPT MathML tests and now run them all, we remove
imported/mathml-in-html5 and the associated TestExpectations failures. Two cases unrelated to
font loading are still failing: One for the SuperscriptShiftUpCramped parameter (bug 156401)
and one for the RadicalDegreeBottomRaisePercent parameter (bug 183631).

LayoutTests/imported/w3c:

Reviewed by Manuel Rego Casasnovas.

* web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt.
* web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html: Import font loading workaround.
* web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt.
* web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html: Import font loading workaround.
* web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html: Import font loading workaround.
* web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1-expected.txt.
Also add the failure with RadicalDegreeBottomRaisePercent.
* web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html: Import font loading workaround.
* web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt.
Also add the failure for SuperscriptShiftUpCramped.
* web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html: Import font loading workaround.
* web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt.
* web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html: Import font loading workaround.
* web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt.
* web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html: Import font loading workaround.
* web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt.
* web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html: Import font loading workaround.
* web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt.
* web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html: Import font loading workaround.
* web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html: Import font loading workaround.
* web-platform-tests/mathml/relations/css-styling/displaystyle-1.html: Import font loading workaround.
* web-platform-tests/mathml/relations/css-styling/lengths-3.html: Import font loading workaround.
* web-platform-tests/mathml/tools/utils/misc.py: Import update to Python 3.
(downloadWithProgressBar):

LayoutTests:

* TestExpectations: Unskip MathML WPT tests.
* imported/mathml-in-html5/LICENSE: Removed.
* imported/mathml-in-html5/README.md: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4.html: Removed.
* platform/mac-wk2/TestExpectations: Remove the expectation.
* platform/win/TestExpectations: Remove the expectation.

Canonical link: https://commits.webkit.org/199283@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
fred-wang committed Mar 14, 2018
1 parent 682087e commit 0f559af4946d64d913f1e4ecd0056e5635b52944
Showing with 107 additions and 1,986 deletions.
  1. +31 −0 LayoutTests/ChangeLog
  2. +0 −11 LayoutTests/TestExpectations
  3. +0 −3 LayoutTests/imported/mathml-in-html5/LICENSE
  4. +0 −47 LayoutTests/imported/mathml-in-html5/README.md
  5. +0 −243 LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html
  6. +0 −175 LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2.html
  7. +0 −212 LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1.html
  8. +0 −338 LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1.html
  9. +0 −145 LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1.html
  10. +0 −145 LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2.html
  11. +0 −324 LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3.html
  12. +0 −324 LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4.html
  13. +44 −0 LayoutTests/imported/w3c/ChangeLog
  14. 0 ...ml5 → w3c/web-platform-tests}/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt
  15. +2 −1 ...Tests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html
  16. 0 ...ml5 → w3c/web-platform-tests}/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt
  17. +2 −1 ...Tests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html
  18. +2 −1 ...tTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html
  19. +1 −1 ...tml5 → w3c/web-platform-tests}/mathml/presentation-markup/radicals/root-parameters-1-expected.txt
  20. +2 −1 ...tTests/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html
  21. +1 −0 ...ml5 → w3c/web-platform-tests}/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt
  22. +2 −1 ...Tests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html
  23. 0 ... → w3c/web-platform-tests}/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt
  24. +2 −1 ...ts/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html
  25. 0 ... → w3c/web-platform-tests}/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt
  26. +2 −1 ...ts/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html
  27. 0 ... → w3c/web-platform-tests}/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt
  28. +2 −1 ...ts/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html
  29. 0 ... → w3c/web-platform-tests}/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt
  30. +2 −1 ...ts/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html
  31. +2 −1 LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html
  32. +2 −1 LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-1.html
  33. +2 −1 LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/lengths-3.html
  34. +6 −3 LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/misc.py
  35. +0 −2 LayoutTests/platform/mac-wk2/TestExpectations
  36. +0 −1 LayoutTests/platform/win/TestExpectations
@@ -1,3 +1,34 @@
2018-03-14 Frederic Wang <fwang@igalia.com>

Finish migration to MathML WPT tests
https://bugs.webkit.org/show_bug.cgi?id=183628

Reviewed by Manuel Rego Casasnovas.

In r225162, the MathML tests from the WPT repository were imported. They were intended to
replace the ones in imported/mathml-in-html5 but the migration was not fully possible. The
main issue was that many MathML tests use Web fonts to test the use of OpenType parameters
but document.fonts.ready is unreliable in WebKit (bug 174030). A workaround was implemented
in WPT ( https://github.com/w3c/web-platform-tests/pull/10025 ) so this commit finishes
the migration. We update the WPT MathML tests and now run them all, we remove
imported/mathml-in-html5 and the associated TestExpectations failures. Two cases unrelated to
font loading are still failing: One for the SuperscriptShiftUpCramped parameter (bug 156401)
and one for the RadicalDegreeBottomRaisePercent parameter (bug 183631).

* TestExpectations: Unskip MathML WPT tests.
* imported/mathml-in-html5/LICENSE: Removed.
* imported/mathml-in-html5/README.md: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3.html: Removed.
* imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4.html: Removed.
* platform/mac-wk2/TestExpectations: Remove the expectation.
* platform/win/TestExpectations: Remove the expectation.

2018-03-13 John Wilander <wilander@apple.com>

Resource Load Statistics: Immediately forward cookie access for domains with previous user interaction when there's an opener document
@@ -591,17 +591,6 @@ imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace.html
imported/w3c/web-platform-tests/html/browsers/windows/nested-browsing-contexts/frameElement.sub.html [ Pass Failure ]
imported/w3c/web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub.html [ Pass Failure ]

# These MathML WPT tests are skipped because they are executed before Web fonts are available.
# For now, tweaked versions remain in LayoutTests/imported/mathml-in-html5/.
webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html [ Skip ]
webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html [ Skip ]
webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html [ Skip ]
webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html [ Skip ]
webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html [ Skip ]
webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html [ Skip ]
webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html [ Skip ]
webkit.org/b/174030 imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html [ Skip ]

# These MathML WPT tests fail.
webkit.org/b/180013 imported/w3c/web-platform-tests/mathml/relations/css-styling/lengths-1.html [ ImageOnlyFailure ]
webkit.org/b/180013 imported/w3c/web-platform-tests/mathml/relations/css-styling/lengths-2.html [ ImageOnlyFailure ]

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit 0f559af

Please sign in to comment.