[EFL][GTK] Volume slider only changes volume when thumb is released, …

…not while dragging

https://bugs.webkit.org/show_bug.cgi?id=156970

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Volume slider have to change the volume while dragging the thumb.

Test: media/video-volume-slider-drag.html

* Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.createControls): Use the 'input' event instead of the 'change' to
check the changed value correctly.
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderInput): Renamed from handleVolumeSliderChange.
(Controller.prototype.handleVolumeSliderChange): Deleted.

LayoutTests:

Removed the passed test.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:


Canonical link: https://commits.webkit.org/175180@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@200126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog

@@ -1,3 +1,15 @@
+2016-04-27  Hunseop Jeong  <hs85.jeong@samsung.com>
+
+        [EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging
+        https://bugs.webkit.org/show_bug.cgi?id=156970
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Removed the passed test.
+
+        * platform/efl/TestExpectations:
+        * platform/gtk/TestExpectations:
+
 2016-04-26  Dean Jackson  <dino@apple.com>
 
         RTL native <select> buttons should have arrows on left

LayoutTests/platform/efl/TestExpectations

@@ -2682,6 +2682,5 @@ webkit.org/b/156969 media/video-display-toggle.html [ Failure ]
 webkit.org/b/156969 media/video-initially-hidden-volume-slider-up.html [ Failure ]
 webkit.org/b/156969 media/video-playing-and-pause.html [ Failure ]
 webkit.org/b/156969 media/video-restricted-no-preload-auto.html [ Failure ]
-webkit.org/b/156969 media/video-volume-slider-drag.html [ Failure ]
 webkit.org/b/156969 media/video-zoom-controls.html [ Failure ]
 webkit.org/b/156969 media/volume-bar-empty-when-muted.html [ Failure ]

LayoutTests/platform/gtk/TestExpectations

@@ -2324,7 +2324,6 @@ webkit.org/b/136673 fast/text/empty-shadow.html [ ImageOnlyFailure ]
 webkit.org/b/137109 accessibility/legend-children-are-visible.html [ Failure ]
 
 webkit.org/b/137695 media/video-controls-audiotracks-trackmenu.html [ Failure ]
-webkit.org/b/138074 media/video-volume-slider-drag.html [ Failure ]
 
 # Font is clipped incorrectly
 webkit.org/b/138077 editing/caret/color-span-inside-editable-background.html [ ImageOnlyFailure ]

Source/WebCore/ChangeLog

@@ -1,3 +1,21 @@
+2016-04-27  Hunseop Jeong  <hs85.jeong@samsung.com>
+
+        [EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging
+        https://bugs.webkit.org/show_bug.cgi?id=156970
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Volume slider have to change the volume while dragging the thumb. 
+
+        Test: media/video-volume-slider-drag.html 
+
+        * Modules/mediacontrols/mediaControlsBase.js:
+        (Controller.prototype.createControls): Use the 'input' event instead of the 'change' to
+        check the changed value correctly.
+        (Controller.prototype.handleMaxButtonClicked):
+        (Controller.prototype.handleVolumeSliderInput): Renamed from handleVolumeSliderChange.
+        (Controller.prototype.handleVolumeSliderChange): Deleted. 
+
 2016-04-27  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 
         [Fetch API] Remove FetchResponse::redirect overload

Source/WebCore/Modules/mediacontrols/mediaControlsBase.js

@@ -390,7 +390,7 @@ Controller.prototype = {
         volume.min = 0;
         volume.max = 1;
         volume.step = .01;
-        this.listenFor(volume, 'change', this.handleVolumeSliderChange);
+        this.listenFor(volume, 'input', this.handleVolumeSliderInput);
 
         var captionButton = this.controls.captionButton = document.createElement('button');
         captionButton.setAttribute('pseudo', '-webkit-media-controls-toggle-closed-captions-button');
@@ -820,7 +820,7 @@ Controller.prototype = {
         this.video.volume = 1;
     },
 
-    handleVolumeSliderChange: function(event)
+    handleVolumeSliderInput: function(event)
     {
         if (this.video.muted) {
             this.video.muted = false;