Skip to content
Permalink
Browse files
[RenderTreeBuilder] Do not use RenderTreeBuilder::current() in Render…
…RubyRun::takeChild

https://bugs.webkit.org/show_bug.cgi?id=182607
<rdar://problem/37355944>

Reviewed by Sam Weinig.

No change in functionality.

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::takeChild):


Canonical link: https://commits.webkit.org/198422@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
alanbujtas committed Feb 8, 2018
1 parent ccb7394 commit 10584b85d209f77a4775b769fc2f5939d59ba012
Showing with 14 additions and 1 deletion.
  1. +13 −0 Source/WebCore/ChangeLog
  2. +1 −1 Source/WebCore/rendering/RenderRubyRun.cpp
@@ -1,3 +1,16 @@
2018-02-08 Zalan Bujtas <zalan@apple.com>

[RenderTreeBuilder] Do not use RenderTreeBuilder::current() in RenderRubyRun::takeChild
https://bugs.webkit.org/show_bug.cgi?id=182607
<rdar://problem/37355944>

Reviewed by Sam Weinig.

No change in functionality.

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::takeChild):

2018-02-08 Antti Koivisto <antti@apple.com>

Use invalidation rulesets for attribute selectors
@@ -110,7 +110,7 @@ RenderPtr<RenderObject> RenderRubyRun::takeChild(RenderTreeBuilder& builder, Ren
if (rightRun.hasRubyBase()) {
RenderRubyBase* rightBase = rightRun.rubyBase();
// Collect all children in a single base, then swap the bases.
RenderTreeBuilder::current()->moveRubyChildren(*rightBase, *base);
builder.moveRubyChildren(*rightBase, *base);
moveChildTo(builder, &rightRun, base, RenderBoxModelObject::NormalizeAfterInsertion::No);
rightRun.moveChildTo(builder, this, rightBase, RenderBoxModelObject::NormalizeAfterInsertion::No);
// The now empty ruby base will be removed below.

0 comments on commit 10584b8

Please sign in to comment.