Skip to content
Permalink
Browse files
TestNetscapePlugIn: Address review comment on r193607
<http://webkit.org/b/151881>

* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(testSetStatus): Initializing std::unique_ptr<char[]> with
nullptr is redundant.

Canonical link: https://commits.webkit.org/170073@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@193623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
ddkilzer committed Dec 7, 2015
1 parent 04aecba commit 113a553daca66ba3a520c7406c3c87f69fa1bb37
Showing with 10 additions and 1 deletion.
  1. +9 −0 Tools/ChangeLog
  2. +1 −1 Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp
@@ -1,3 +1,12 @@
2015-12-07 David Kilzer <ddkilzer@apple.com>

TestNetscapePlugIn: Address review comment on 193607
<http://webkit.org/b/151881>

* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(testSetStatus): Initializing std::unique_ptr<char[]> with
nullptr is redundant.

2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>

[GTK] Add webkit_uri_request_get_http_method
@@ -974,7 +974,7 @@ bool testWindowOpen(NPP npp)

static bool testSetStatus(PluginObject* obj, const NPVariant* args, uint32_t argCount, NPVariant* result)
{
std::unique_ptr<char[]> message(nullptr);
std::unique_ptr<char[]> message;
if (argCount && NPVARIANT_IS_STRING(args[0])) {
NPString statusString = NPVARIANT_TO_STRING(args[0]);
message = toCString(statusString);

0 comments on commit 113a553

Please sign in to comment.