Web Inspector: CRASH when reopening tab with docked inspector on cras…

…hed page https://bugs.webkit.org/show_bug.cgi?id=196954 <rdar://problem/48716433> Reviewed by Ryosuke Niwa. * UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Canonical link: https://commits.webkit.org/211225@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Apr 16, 2019 · 143ca57 · 143ca57
1 parent d3b6be8
commit 143ca57
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
@@ -1,3 +1,14 @@
+2019-04-15  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: CRASH when reopening tab with docked inspector on crashed page
+        https://bugs.webkit.org/show_bug.cgi?id=196954
+        <rdar://problem/48716433>
+
+        Reviewed by Ryosuke Niwa.
+
+        * UIProcess/mac/WebInspectorProxyMac.mm:
+        (WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
+
 2019-04-15  Chris Dumez  <cdumez@apple.com>
 
         URL set by document.open() is not communicated to the UIProcess

diff --git a/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm b/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm
@@ -562,6 +562,9 @@ - (void)inspectorViewControllerDidMoveToWindow:(WKInspectorViewController *)insp
         return;
     }
 
+    if (!inspectedPage())
+        return;
+
     NSView *inspectedView = inspectedPage()->inspectorAttachmentView();
     WKWebView *inspectorView = [m_inspectorViewController webView];